Red Hat Bugzilla – Bug 245879
Review Request: stardict-dic-ja - Japanese(ja) dictionaries for StarDict
Last modified: 2007-11-30 17:12:08 EST
Spec URL: http://reciteword.cosoft.org.cn/redhat/stardict-dic-ja.spec SRPM URL: http://reciteword.cosoft.org.cn/redhat/stardict-dic-ja-2.4.2-3.fc7.src.rpm Description: Japanese(ja) dictionaries for StarDict
MUSTFIX: Use %{_datadir} instead of /usr/share on these occations: mkdir -p ${RPM_BUILD_ROOT}/usr/share/stardict/dic cp -rf stardict-* ${RPM_BUILD_ROOT}/usr/share/stardict/dic/
OK. Fixed as the same file. Thank you! :)
Notice, because of bandwidth issue, I didn't upload the newest SRPM, you can download the old srpm, replace the spec file with the newest one and rebuild to get the newest srpm file.
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. 0aa46b7d589a01663c3fb465152db85d stardict-edict-2.4.2.tar.bz2 e0f60d6acc4e3df6784805816b2e136f stardict-jmdict-en-ja-2.4.2.tar.bz2 2c574aef86a5d7bab45395d7e8ee7f6b stardict-jmdict-ja-en-2.4.2.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. - License text is NOT included in package. - no %doc files present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains content. + no static libraries. + no .pc files are present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. + Requires: stardict >= 2.4.2 APPROVED.
New Package CVS Request ======================= Package Name: stardict-dic-ja Short Description: Japanese(ja) dictionaries for StarDict Owners: zhu@redhat.com Branches: F-7 InitialCC:
stardict-dic-ja-2.4.2-3.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.