Bug 245883 - Review Request: stardict-dic-zh_TW - Traditional Chinese(zh_TW) dictionaries for StarDict
Summary: Review Request: stardict-dic-zh_TW - Traditional Chinese(zh_TW) dictionaries ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-06-27 05:44 UTC by Hu Zheng
Modified: 2008-09-09 06:07 UTC (History)
5 users (show)

Fixed In Version: 2.4.2-3.fc7
Clone Of:
Environment:
Last Closed: 2007-07-05 19:23:30 UTC
Type: ---
Embargoed:
panemade: fedora-review+
wtogami: fedora-cvs+


Attachments (Terms of Use)

Description Hu Zheng 2007-06-27 05:44:27 UTC
Spec URL:
http://reciteword.cosoft.org.cn/redhat/stardict-dic-zh_TW.spec
SRPM URL:
http://reciteword.cosoft.org.cn/redhat/stardict-dic-zh_TW-2.4.2-3.fc7.src.rpm

Description: 
Traditional Chinese(zh_TW) dictionaries for StarDict

Comment 1 Hu Zheng 2007-07-02 04:01:32 UTC
Notice, because of bandwidth issue, I didn't upload the newest SRPM, you can
download the old srpm, replace the spec file with the newest one and rebuild to
get the newest srpm file.


Comment 2 Parag AN(पराग) 2007-07-02 04:30:24 UTC
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and RPM.
+ source files match upstream.
0349198b9dfcecd9a0f505512bb21d8b  stardict-cdict-big5-2.4.2.tar.bz2
80b13d05bd5e975c35afcf4a13113673  stardict-cedict-big5-2.4.2.tar.bz2
50b9423fa578988b5b0544c5b663058a  stardict-langdao-ce-big5-2.4.2.tar.bz2
61ceeec1b056a171645af723d3e956fe  stardict-langdao-ec-big5-2.4.2.tar.bz2
e54da1d0759ce59f8fbddff7979e9300  stardict-oxford-big5-2.4.2.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
- License text is NOT included in package.
- no %doc files present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains content.
+ no static libraries.
+ no .pc files are present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.
+ Requires: stardict >= 2.4.2

APPROVED.


Comment 3 Hu Zheng 2007-07-02 05:32:57 UTC
New Package CVS Request
=======================
Package Name: stardict-dic-zh_TW
Short Description: Traditional Chinese(zh_TW) dictionaries for StarDict
Owners: zhu
Branches: F-7
InitialCC: 

Comment 4 Fedora Update System 2007-07-05 19:23:26 UTC
stardict-dic-zh_TW-2.4.2-3.fc7 has been pushed to the Fedora 7 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.