Spec URL: https://music.fedorapeople.org/python-embreex.spec SRPM URL: https://music.fedorapeople.org/python-embreex-4.4.0-1.fc43.src.rpm Description: A fork of https://github.com/scopatz/pyembree configured to build wheels on various platforms and Python interpreters. The name change is to avoid confusion with the other forks and install methods available. The goal is to meet the upstream trimesh[easy] preferences for dependencies. Fedora Account System Username: music This package will enable more optional functionality in the existing python-trimesh package.
Copr build: https://copr.fedorainfracloud.org/coprs/build/10388494 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2461413-python-embreex/fedora-rawhide-x86_64/10388494-python-embreex/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel ===== MUST items ===== C/C++: [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD 2-Clause License", "Unknown or generated". 18 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/reviews/python-embreex/2461413-python- embreex/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/python3.14/site- packages, /usr/lib64/python3.14 [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 4281 bytes in 3 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-embreex-4.4.0-1.fc45.x86_64.rpm python-embreex-4.4.0-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpl1avfdkd')] checks: 32, packages: 2 python3-embreex.x86_64: E: zero-length /usr/lib64/python3.14/site-packages/embreex/__init__.pxd python-embreex.src: E: spelling-error ('trimesh', '%description -l en_US trimesh -> trimester, trimmest') python3-embreex.x86_64: E: spelling-error ('trimesh', '%description -l en_US trimesh -> trimester, trimmest') 2 packages and 0 specfiles checked; 3 errors, 0 warnings, 7 filtered, 3 badness; has taken 0.7 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python3-embreex.x86_64: E: zero-length /usr/lib64/python3.14/site-packages/embreex/__init__.pxd python3-embreex.x86_64: E: spelling-error ('trimesh', '%description -l en_US trimesh -> trimester, trimmest') 1 packages and 0 specfiles checked; 2 errors, 0 warnings, 3 filtered, 2 badness; has taken 0.3 s Unversioned so-files -------------------- python3-embreex: /usr/lib64/python3.14/site-packages/embreex/mesh_construction.cpython-314-x86_64-linux-gnu.so python3-embreex: /usr/lib64/python3.14/site-packages/embreex/rtcore.cpython-314-x86_64-linux-gnu.so python3-embreex: /usr/lib64/python3.14/site-packages/embreex/rtcore_scene.cpython-314-x86_64-linux-gnu.so Source checksums ---------------- https://github.com/trimesh/embreex/archive/4.4.0/embreex-4.4.0.tar.gz : CHECKSUM(SHA256) this package : 8434e8ce31cb9e6dc878efd2e9776e4bce146132d3c300e8762969ed0d2be25b CHECKSUM(SHA256) upstream package : 8434e8ce31cb9e6dc878efd2e9776e4bce146132d3c300e8762969ed0d2be25b Requires -------- python3-embreex (rpmlib, GLIBC filtered): libc.so.6()(64bit) libembree4.so.4()(64bit) python(abi) python3.14dist(numpy) rtld(GNU_HASH) Provides -------- python3-embreex: python-embreex python3-embreex python3-embreex(x86-64) python3.14-embreex python3.14dist(embreex) python3dist(embreex) Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2461413 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Python Disabled plugins: C/C++, Ocaml, fonts, PHP, SugarActivity, Haskell, Java, Perl, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Approved.
Thank you for the review! https://release-monitoring.org/project/356617/
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-embreex Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
FEDORA-2026-94242a8e77 (python-embreex-4.4.0-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-94242a8e77
FEDORA-2026-0b3a9720fc (python-embreex-4.4.0-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2026-0b3a9720fc
FEDORA-2026-94242a8e77 (python-embreex-4.4.0-1.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2026-0293e8cac6 (python-embreex-4.4.0-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2026-0293e8cac6
FEDORA-2026-65523b5226 (python-embreex-4.4.0-1.fc44 and python-trimesh-4.12.1-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-65523b5226
FEDORA-2026-65523b5226 has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-65523b5226` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-65523b5226 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-0293e8cac6 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-0293e8cac6 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-0293e8cac6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-0b3a9720fc has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-0b3a9720fc \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-0b3a9720fc See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-0293e8cac6 (python-embreex-4.4.0-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2026-0b3a9720fc (python-embreex-4.4.0-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2026-65523b5226 (python-embreex-4.4.0-1.fc44 and python-trimesh-4.12.2-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.