Bug 2463819 - Review Request: rust-abol - High-performance, asynchronous, dictionary-driven RADIUS framework
Summary: Review Request: rust-abol - High-performance, asynchronous, dictionary-driven...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/abol
Whiteboard:
Depends On: 2463808 2463818
Blocks:
TreeView+ depends on / blocked
 
Reported: 2026-04-29 14:09 UTC by Andreas Schneider
Modified: 2026-07-07 09:57 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-07-07 09:57:38 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 10666287 to 10667358 (2.08 KB, patch)
2026-07-01 08:42 UTC, Fedora Review Service
no flags Details | Diff

Description Andreas Schneider 2026-04-29 14:09:23 UTC
Spec URL: https://asn.fedorapeople.org/rust-abol-codegen.spec
SRPM URL: https://asn.fedorapeople.org/rust-abol-0.1.0-1.fc45.src.rpm
Description: A high-performance, asynchronous, dictionary-driven RADIUS framework
Fedora Account System Username: asn

Comment 1 Fedora Review Service 2026-04-29 14:13:02 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10406338
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2463819-rust-abol/fedora-rawhide-x86_64/10406338-rust-abol/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Andreas Schneider 2026-06-23 11:44:35 UTC
Spec URL: https://asn.fedorapeople.org/rust-abol-codegen.spec
SRPM URL: https://asn.fedorapeople.org/rust-abol-0.1.0-2.fc45.src.rpm

Added LICENSE files and README.md

Comment 3 Fabio Valentini 2026-06-30 12:32:36 UTC
Looks like you linked the wrong .spec file here?

Comment 5 Fabio Valentini 2026-06-30 14:46:37 UTC
Thanks, the links work now.

I see one minor issue and one medium-sized blocker:

Looks like you copy-pasted the rust2rpm.config from other abol-* crates to this one, but it's actually not necessary here:
This top-level crate already includes all the files that are separately included (LICENSE, LICENSE-APACHE, README.md).
Just drop the rust2rpm.toml config for additional source files, doc-files / license-files overrides, and scripts.prep.pre.

It looks like this crate also includes some unused (?) files that are not covered by the MIT / Apache-2.0 license under dictionaries/* - these all have CC-BY-4.0 license headers. If they are indeed unused (I see no references to them in "abol-0.1.0" crate sources), you either need to "rm" those files in %prep (i.e. `rm -vr dictionaries/`) or exclude them from packaged crates (i.e. add something like `%exclude %{crate_instdir}/dictionaries/` to the %files list for the -devel subpackage). Settings for both are available in rust2rpm.toml (scripts.prep.post or package.exclude-crate-files).

Comment 6 Fedora Review Service 2026-07-01 01:02:18 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10666287
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2463819-rust-abol/fedora-rawhide-x86_64/10666287-rust-abol/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 8 Fedora Review Service 2026-07-01 08:42:22 UTC
Created attachment 2147247 [details]
The .spec file difference from Copr build 10666287 to 10667358

Comment 9 Fedora Review Service 2026-07-01 08:42:24 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10667358
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2463819-rust-abol/fedora-rawhide-x86_64/10667358-rust-abol/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 10 Fabio Valentini 2026-07-06 19:39:55 UTC
Package was generated with rust2rpm, simplifying the review.

It looks like running the tests would require enabling the "tokio" feature.
This would be a nice-to-have, but doesn't block the review.

You could do this with the following rust2rpm.toml snippet:

```
[features]
enable = ["tokio"]
```

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
🫤 test suite is run and all unit tests pass:
   No tests are run.
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

Comment 11 Fedora Admin user for bugzilla script actions 2026-07-07 09:41:16 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-abol
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

Comment 12 Fedora Update System 2026-07-07 09:51:59 UTC
FEDORA-2026-6536e9130a (rust-abol-0.1.0-1.fc45) has been submitted as an update to Fedora 45.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-6536e9130a

Comment 13 Fedora Update System 2026-07-07 09:57:38 UTC
FEDORA-2026-6536e9130a (rust-abol-0.1.0-1.fc45) has been pushed to the Fedora 45 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.