Bug 2463818 - Review Request: rust-abol-codegen - Code generation tools and RADIUS dictionary definitions
Summary: Review Request: rust-abol-codegen - Code generation tools and RADIUS dictiona...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/abol-codegen
Whiteboard:
Depends On: 2463810
Blocks: 2463819
TreeView+ depends on / blocked
 
Reported: 2026-04-29 14:02 UTC by Andreas Schneider
Modified: 2026-06-24 14:31 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-06-24 14:31:14 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Andreas Schneider 2026-04-29 14:02:06 UTC
Spec URL: https://asn.fedorapeople.org/rust-abol-codegen.spec
SRPM URL: https://asn.fedorapeople.org/rust-abol-codegen-0.1.0-1.fc45.src.rpm
Description: Code generation tools and RADIUS dictionary definitions for Abol
Fedora Account System Username: asn

Comment 1 Fedora Review Service 2026-04-29 14:02:18 UTC
There seems to be some problem with the following file.
SRPM URL: https://asn.fedorapeople.org/rust-abol-codegen-0.1.0-1.fc45.src.rpm
Fetching it results in a 404 Not Found error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Andreas Schneider 2026-04-29 14:05:15 UTC
cat rust2rpm.toml   
[package]
extra-sources = [
    { number = 2, file = "LICENSE", comments = [
        "See https://github.com/Abel981/abol/blob/main/LICENSE",
        "Merge Request: https://github.com/Abel981/abol/pull/3",
    ] },
    { number = 3, file = "LICENSE-APACHE", comments = [
        "See https://github.com/Abel981/abol/blob/main/LICENSE-APACHE",
        "Merge Request: https://github.com/Abel981/abol/pull/3",
    ] },
    { number = 4, file = "README.md", comments = [
        "See https://github.com/Abel981/abol/blob/main/README.md",
        "Merge Request: https://github.com/Abel981/abol/pull/3",
    ] },
]
license-files = ["LICENSE", "LICENSE-APACHE"]
doc-files = ["README.md"]

[scripts]
prep.pre = [
    "cp %{SOURCE2} .",
    "cp %{SOURCE3} .",
    "cp %{SOURCE4} ."
]
install.post = [
    "install -m 0644 LICENSE %{buildroot}%{crate_instdir}/LICENSE",
    "install -m 0644 LICENSE %{buildroot}%{crate_instdir}/LICENSE-APACHE"
]

Spec URL: https://asn.fedorapeople.org/rust-abol-codegen.spec
SRPM URL: https://asn.fedorapeople.org/rust-abol-codegen-0.1.0-1.fc45.src.rpm

Comment 3 Fedora Review Service 2026-04-29 14:07:23 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10406314
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2463818-rust-abol-codegen/fedora-rawhide-x86_64/10406314-rust-abol-codegen/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fabio Valentini 2026-06-23 09:20:14 UTC
Same comments from there also apply here:
https://bugzilla.redhat.com/show_bug.cgi?id=2463755#c3

Comment 8 Fabio Valentini 2026-06-23 21:33:15 UTC
Assuming you make the same adaptations as for rust-abol-util, this looks good to me.

===

Looks good to me now. Thanks!

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
🫤 license files are included with %license in %files:
   temporarily manually included from upstream,
   this workaround can be dropped as soon as the files are included in published crates.
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

Comment 9 Fedora Admin user for bugzilla script actions 2026-06-24 14:09:07 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-abol-codegen
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

Comment 10 Fedora Update System 2026-06-24 14:27:00 UTC
FEDORA-2026-24b72ff2a7 (rust-abol-codegen-0.1.0-1.fc45) has been submitted as an update to Fedora 45.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-24b72ff2a7

Comment 11 Fedora Update System 2026-06-24 14:31:14 UTC
FEDORA-2026-24b72ff2a7 (rust-abol-codegen-0.1.0-1.fc45) has been pushed to the Fedora 45 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.