Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://rathann.fedorapeople.org/review/rust-tls_codec_derive/rust-tls_codec_derive.spec SRPM URL: https://rathann.fedorapeople.org/review/rust-tls_codec_derive/rust-tls_codec_derive-0.4.2-1.fc45.src.rpm Description: This crate implements the TLS codec as defined in RFC 8446 as well as some extensions required by MLS. Fedora Account System Username: rathann
Copr build: https://copr.fedorainfracloud.org/coprs/build/10583989 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2487074-rust-tls_codec_derive/fedora-rawhide-x86_64/10583989-rust-tls_codec_derive/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The package is APPROVED, but please document the justification for disabling tests when you import it, as suggested in detail below. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated The spec file is generated by rust2rpm, simplifying the review. The tests are disabled without a justifying comment. Please add one. You can do something like this in rust2rpm.toml: [tests] run = false comments = [ "Avoid a dependency cycle with tls_codec", ] Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/tls_codec_derive-0.4.2/LICENSE-APACHE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files OK: not a serious problem; due to reasonable rust2rpm design decisions ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "MIT License". 17 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2487074-rust- tls_codec_derive/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- tls_codec_derive-devel , rust-tls_codec_derive+default-devel , rust- tls_codec_derive+conditional_deserialization-devel , rust- tls_codec_derive+std-devel [?]: Package functions as described. (Tests are disabled.) [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=146607647 [!]: %check is present and all tests pass. Tests are disabled. This is justifiable (to prevent a dependency cycle with tls_codec), but the justification should be documented. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: rust-tls_codec_derive-devel-0.4.2-1.fc45.noarch.rpm rust-tls_codec_derive+default-devel-0.4.2-1.fc45.noarch.rpm rust-tls_codec_derive+conditional_deserialization-devel-0.4.2-1.fc45.noarch.rpm rust-tls_codec_derive+std-devel-0.4.2-1.fc45.noarch.rpm rust-tls_codec_derive-0.4.2-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp33j7h14e')] checks: 32, packages: 5 5 packages and 0 specfiles checked; 0 errors, 0 warnings, 25 filtered, 0 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 4 packages and 0 specfiles checked; 0 errors, 0 warnings, 21 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://crates.io/api/v1/crates/tls_codec_derive/0.4.2/download#/tls_codec_derive-0.4.2.crate : CHECKSUM(SHA256) this package : 2d2e76690929402faae40aebdda620a2c0e25dd6d3b9afe48867dfd95991f4bd CHECKSUM(SHA256) upstream package : 2d2e76690929402faae40aebdda620a2c0e25dd6d3b9afe48867dfd95991f4bd Requires -------- rust-tls_codec_derive-devel (rpmlib, GLIBC filtered): (crate(proc-macro2/default) >= 1.0.0 with crate(proc-macro2/default) < 2.0.0~) (crate(quote/default) >= 1.0.0 with crate(quote/default) < 2.0.0~) (crate(syn/default) >= 2.0.0 with crate(syn/default) < 3.0.0~) (crate(syn/parsing) >= 2.0.0 with crate(syn/parsing) < 3.0.0~) cargo rust rust-tls_codec_derive+default-devel (rpmlib, GLIBC filtered): cargo crate(tls_codec_derive) crate(tls_codec_derive/std) rust-tls_codec_derive+conditional_deserialization-devel (rpmlib, GLIBC filtered): (crate(syn/full) >= 2.0.0 with crate(syn/full) < 3.0.0~) cargo crate(tls_codec_derive) rust-tls_codec_derive+std-devel (rpmlib, GLIBC filtered): cargo crate(tls_codec_derive) Provides -------- rust-tls_codec_derive-devel: crate(tls_codec_derive) rust-tls_codec_derive-devel rust-tls_codec_derive+default-devel: crate(tls_codec_derive/default) rust-tls_codec_derive+default-devel rust-tls_codec_derive+conditional_deserialization-devel: crate(tls_codec_derive/conditional_deserialization) rust-tls_codec_derive+conditional_deserialization-devel rust-tls_codec_derive+std-devel: crate(tls_codec_derive/std) rust-tls_codec_derive+std-devel Diff spec file in url and in SRPM --------------------------------- --- /home/ben/fedora/review/2487074-rust-tls_codec_derive/srpm/rust-tls_codec_derive.spec 2026-06-13 08:47:45.848257114 +0100 +++ /home/ben/fedora/review/2487074-rust-tls_codec_derive/srpm-unpacked/rust-tls_codec_derive.spec 2026-06-07 01:00:00.000000000 +0100 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.8.4) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + # Generated by rust2rpm 28 %bcond check 0 @@ -91,3 +101,7 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Sun Jun 07 2026 Dominik 'Rathann' Mierzejewski <dominik> - 0.4.2-1 +- initial package +- disable tests to bootstrap without tls_codec (circular dependency) +## END: Generated by rpmautospec Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2487074 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Ocaml, PHP, Python, Haskell, Perl, C/C++, SugarActivity, fonts, Java, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH