Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://raw.githubusercontent.com/containers/oci-delta/refs/heads/main/build/package/rpm/oci-delta.spec SRPM URL: https://packages.redhat.com/api/pulp-content/public-copr/saypaul/oci-delta/fedora-rawhide-x86_64/Packages/o/oci-delta-0.2.0-1.fc45.src.rpm Description: Create and apply delta files between OCI image archives Fedora Account System Username: saypaul
[fedora-review-service-build]
I'm not a reviewer yet. Fedora's packaging guidelines recommend specifying `pkgconfig(foo) BuildRequires` for packages built using pkg-config for libraries, so the following might be better. ``` BuildRequires: pkgconfig(ostree-1) ``` https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequires/
Spec URL: https://raw.githubusercontent.com/say-paul/oci-delta/refs/heads/fedora-dist-git/build/package/rpm/oci-delta.spec SPRM URL: https://packages.redhat.com/api/pulp-content/public-copr/saypaul/oci-delta/fedora-rawhide-x86_64/Packages/o/oci-delta-0.2.0-1.fc45.src.rpm
rpmlint complains: oci-delta.spec: W: invalid-url Source1: oci-delta-0.2.0-vendor.tar.bz2 But, that is just how go-vendor-tools works Per the review guidelines We should work to add a manpage upstream.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. Note: The license is extracted automatically by go-vendor-tols, is there a way to get the license listed in the modules.txt? [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. Note: As per earlier comment, "pkgconfig(ostree-1)" is the recommended better build requires here. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 15263 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). [x]: Rpmlint is run on all installed packages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: oci-delta-0.2.0-1.fc45.x86_64.rpm oci-delta-0.2.0-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpl2g4hc0r')] checks: 32, packages: 2 oci-delta.src: E: spelling-error ('bootc', '%description -l en_US bootc -> boot, boots, booth') oci-delta.x86_64: E: spelling-error ('bootc', '%description -l en_US bootc -> boot, boots, booth') oci-delta.x86_64: W: no-manual-page-for-binary oci-delta oci-delta.spec: W: invalid-url Source1: oci-delta-0.2.0-vendor.tar.bz2 2 packages and 0 specfiles checked; 2 errors, 2 warnings, 7 filtered, 2 badness; has taken 0.4 s Notes: * The "bootc" spelling is correct, "bootc" is just not in the dictionary * We should work upstream to add a manpage * The vendor source has no officinal url, as it is generated by go-vendor-tools Rpmlint (debuginfo) ------------------- Checking: oci-delta-debuginfo-0.2.0-1.fc45.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp7ep7qmfi')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.4 Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 oci-delta.x86_64: E: spelling-error ('bootc', '%description -l en_US bootc -> boot, boots, booth') oci-delta.x86_64: W: no-manual-page-for-binary oci-delta 2 packages and 0 specfiles checked; 1 errors, 1 warnings, 9 filtered, 1 badness; has taken 0.2 s Notes: * The "bootc" spelling is correct, "bootc" is just not in the dictionary Source checksums ---------------- https://github.com/containers/oci-delta/archive/v0.2.0/oci-delta-0.2.0.tar.gz : CHECKSUM(SHA256) this package : f3cb8e449ce3e8f329ef194489869a895a3183acb5b70f0db1aa88d1549126a4 CHECKSUM(SHA256) upstream package : f3cb8e449ce3e8f329ef194489869a895a3183acb5b70f0db1aa88d1549126a4 Using local file /var/tmp/rev/oci-delta-0.2.0-vendor.tar.bz2 as upstream file:///var/tmp/rev/oci-delta-0.2.0-vendor.tar.bz2 : CHECKSUM(SHA256) this package : 11ba006648140e0bbbdc5f5ba9e3e1f347be4c567c194b1e67a671f44d7ae8f2 CHECKSUM(SHA256) upstream package : 11ba006648140e0bbbdc5f5ba9e3e1f347be4c567c194b1e67a671f44d7ae8f2 Notes: * The vendor source is automatically created by go-vendor-tools from the source. Requires -------- oci-delta (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libostree-1.so.1()(64bit) libostree-1.so.1(LIBOSTREE_2016.3)(64bit) libresolv.so.2()(64bit) rtld(GNU_HASH) Provides -------- oci-delta: bundled(golang(github.com/BurntSushi/toml)) bundled(golang(github.com/Microsoft/go-winio)) bundled(golang(github.com/Microsoft/hcsshim)) bundled(golang(github.com/containerd/cgroups/v3)) bundled(golang(github.com/containerd/errdefs)) bundled(golang(github.com/containerd/errdefs/pkg)) bundled(golang(github.com/containerd/stargz-snapshotter/estargz)) bundled(golang(github.com/containerd/typeurl/v2)) bundled(golang(github.com/containers/image/v5)) bundled(golang(github.com/containers/libtrust)) bundled(golang(github.com/containers/ocicrypt)) bundled(golang(github.com/containers/storage)) bundled(golang(github.com/containers/tar-diff)) bundled(golang(github.com/cyphar/filepath-securejoin)) bundled(golang(github.com/docker/docker)) bundled(golang(github.com/docker/go-units)) bundled(golang(github.com/go-jose/go-jose/v4)) bundled(golang(github.com/gogo/protobuf)) bundled(golang(github.com/golang/groupcache)) bundled(golang(github.com/google/go-containerregistry)) bundled(golang(github.com/google/go-intervals)) bundled(golang(github.com/google/uuid)) bundled(golang(github.com/inconshreveable/mousetrap)) bundled(golang(github.com/json-iterator/go)) bundled(golang(github.com/klauspost/compress)) bundled(golang(github.com/klauspost/pgzip)) bundled(golang(github.com/kr/pretty)) bundled(golang(github.com/letsencrypt/boulder)) bundled(golang(github.com/mistifyio/go-zfs/v3)) bundled(golang(github.com/moby/sys/capability)) bundled(golang(github.com/moby/sys/mountinfo)) bundled(golang(github.com/moby/sys/user)) bundled(golang(github.com/modern-go/concurrent)) bundled(golang(github.com/modern-go/reflect2)) bundled(golang(github.com/opencontainers/go-digest)) bundled(golang(github.com/opencontainers/image-spec)) bundled(golang(github.com/opencontainers/runtime-spec)) bundled(golang(github.com/opencontainers/selinux)) bundled(golang(github.com/pkg/errors)) bundled(golang(github.com/rogpeppe/go-internal)) bundled(golang(github.com/secure-systems-lab/go-securesystemslib)) bundled(golang(github.com/sigstore/protobuf-specs)) bundled(golang(github.com/sigstore/sigstore)) bundled(golang(github.com/sirupsen/logrus)) bundled(golang(github.com/spf13/cobra)) bundled(golang(github.com/spf13/pflag)) bundled(golang(github.com/tchap/go-patricia/v2)) bundled(golang(github.com/titanous/rocacheck)) bundled(golang(github.com/ulikunitz/xz)) bundled(golang(github.com/vbatts/tar-split)) bundled(golang(go.opencensus.io)) bundled(golang(golang.org/x/crypto)) bundled(golang(golang.org/x/sync)) bundled(golang(golang.org/x/sys)) bundled(golang(golang.org/x/term)) bundled(golang(google.golang.org/genproto/googleapis/api)) bundled(golang(google.golang.org/genproto/googleapis/rpc)) bundled(golang(google.golang.org/grpc)) bundled(golang(google.golang.org/protobuf)) bundled(golang(gopkg.in/check.v1)) bundled(golang(gopkg.in/yaml.v3)) oci-delta oci-delta(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /var/tmp/rev/2488330-oci-delta/srpm/oci-delta.spec 2026-06-15 10:36:09.710844531 +0200 +++ /var/tmp/rev/2488330-oci-delta/srpm-unpacked/oci-delta.spec 2026-06-15 02:00:00.000000000 +0200 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.8.4) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %bcond check 1 @@ -65,3 +75,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Mon Jun 15 2026 John Doe <packager> - 0.2.0-1 +- Uncommitted changes +## END: Generated by rpmautospec Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2488330 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: SugarActivity, Python, Ocaml, Perl, fonts, PHP, Java, C/C++, Haskell, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Upstream tracking issue for man page is at: https://github.com/containers/oci-delta/issues/15
Yes, that looks good now. Got license data in the module.txt, better build-dep and has a manpage.
The Pagure repository was created at https://src.fedoraproject.org/rpms/oci-delta Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`