Bug 2497353 - Review Request: rust-glycin-test - Sandboxed image decoding
Summary: Review Request: rust-glycin-test - Sandboxed image decoding
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/glycin-test
Whiteboard:
Depends On:
Blocks: 2492988
TreeView+ depends on / blocked
 
Reported: 2026-07-06 13:59 UTC by Fabio Valentini
Modified: 2026-08-11 10:50 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-08-11 10:50:47 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2026-07-06 13:59:36 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-glycin-test.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-glycin-test-2.2.0~alpha-1.fc44.src.rpm
Upstream URL: https://crates.io/crates/glycin-test

Description:
Sandboxed image decoding.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2026-07-06 13:59:58 UTC
A successful build with all dependencies present is available in COPR:
https://copr.fedorainfracloud.org/coprs/decathorpe/glycin-next/monitor/

rust2rpm.toml config file:

```
[package]
license-files = ["LICENSE-LGPL-2.1", "LICENSE-MPL-2.0"]

[[package.extra-sources]]
number = 2
file = "https://gitlab.gnome.org/GNOME/glycin/-/raw/2.2.alpha.4/LICENSE-LGPL-2.1"
comments = ["https://gitlab.gnome.org/GNOME/glycin/-/work_items/305"]

[[package.extra-sources]]
number = 3
file = "https://gitlab.gnome.org/GNOME/glycin/-/raw/2.2.alpha.4/LICENSE-MPL-2.0"
comments = ["https://gitlab.gnome.org/GNOME/glycin/-/work_items/305"]

[scripts]
prep.post = ["cp -pav %{SOURCE2} %{SOURCE3} ."]
```

Comment 2 Michel Lind 2026-07-24 17:25:37 UTC
Please update the binary package's license

# FIXME: paste output of %%cargo_license_summary here
License:        # FIXME
# LICENSE.dependencies contains a full license breakdown

Comment 3 Fabio Valentini 2026-07-30 12:36:08 UTC
Thanks for taking a look - I don't know how I missed the FIXMEs for these two packages.
Since I'm not sure whether we will actually need the glycin-test executable, I'll just drop it for now.

Updated files behind the same URLs:

Spec URL: https://decathorpe.fedorapeople.org/rust-glycin-test.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-glycin-test-2.2.0~alpha-1.fc44.src.rpm

I will update to the latest available version when we're ready to ship the next glycin version, I'd rather not mess with it before then.

Comment 4 Fedora Review Service 2026-07-30 13:48:38 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10793702
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2497353-rust-glycin-test/fedora-rawhide-x86_64/10793702-rust-glycin-test/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Michel Lind 2026-08-06 15:13:55 UTC
LGTM, please rebase on import

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
🫤 latest version of the crate is packaged (spec: 2.2.0~alpha; crates.io: 2.2.0-beta — update)
✅ license matches upstream specification and is acceptable for Fedora (spec & Cargo.toml: MPL-2.0 OR LGPL-2.1-or-later)
🫤 license file is included with %license in %files (included manually)
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: glycin-test
  homepage: https://crates.io/crates/glycin-test
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-glycin-test

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 6 Fabio Valentini 2026-08-07 19:16:04 UTC
Thank you for the review! I'll update as soon as possible, likely in coordination with the glycin update from GNOME 51.beta.

Comment 7 Fedora Admin user for bugzilla script actions 2026-08-07 19:18:13 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-glycin-test
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

Comment 8 Fabio Valentini 2026-08-11 10:50:47 UTC
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2026-592ddc83fc

Update to the latest version will be handled as part of the work for glycin 2.2.beta and loupe 51.beta.


Note You need to log in before you can comment on or make changes to this bug.