Bug 249996 - Review Request: perl-File-chmod - perl module implementing symbolic and ls chmod modes
Summary: Review Request: perl-File-chmod - perl module implementing symbolic and ls ch...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 249807
TreeView+ depends on / blocked
 
Reported: 2007-07-29 06:32 UTC by Ralf Corsepius
Modified: 2014-01-21 19:28 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-08-06 14:26:49 UTC
Type: ---
Embargoed:
j: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Ralf Corsepius 2007-07-29 06:32:39 UTC
Spec URL: http://corsepiu.fedorapeople.org/packages/perl-File-chmod.spec
SRPM URL: http://corsepiu.fedorapeople.org/packages/perl-File-chmod-0.32-1.fc8.src.rpm
Description: Perl dist implementing symbolic and ls chmod modes

This perl-module is a prerequisite to be able to upgrade perl-Test-Inline.


Special thanks to J. Pinyan (File::chmod maintainer), 
M. Schwern and A. Kennedy (Test::Inline maintainers)
for having changed File::chmod's licensing upon request, 
remarkably fast in a way, such that File::chmod now can be 
shipped with Fedora. Thank you, guys!

Comment 1 Jason Tibbitts 2007-07-29 18:07:11 UTC
Looks clean and builds fine; there's not much to say.  The description is a bit
thin but I don't think it's a blocker.

* source files match upstream:
   ec54997c4274ca27e8e8d25585223569b15b16ed2bfdf5d0507c57787d6d05a9  
   File-chmod-0.32.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(File::chmod) = 0.32
   perl-File-chmod = 0.32-1.fc8
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(Exporter)
   perl(strict)
   perl(vars)
* %check is present and all tests pass:
   ok 1
   original state of chmod.pm: 00644
   calling: chmod('+x', 'chmod.pm')... chmod.pm: 00755
   calling: chmod('-x', 'chmod.pm')... chmod.pm: 00644
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

Comment 2 Ralf Corsepius 2007-07-31 03:36:25 UTC
New Package CVS Request
=======================
Package Name: perl-File-chmod
Short Description: Implementing symbolic and ls chmod modes
Owners: rc040203
Branches: F-7 FC-6
InitialCC: fedora-perl-devel-list

Comment 3 Kevin Fenzi 2007-07-31 05:48:11 UTC
cvs done.

Comment 4 Ralf Corsepius 2007-08-06 14:26:49 UTC
Whom do I need to bribe to have this package released?

Comment 5 Jesse Keating 2007-08-06 14:52:09 UTC
Ralf, you'd need to click "Push to testing" or "Push to stable" in your bodhi
update page:
https://admin.fedoraproject.org/updates/pending/F7/perl-File-chmod-0.32-1.fc7

I'll do it for you to -testing.

Comment 6 Ralf Corsepius 2007-08-06 15:09:36 UTC
(In reply to comment #5)
> Ralf, you'd need to click "Push to testing" or "Push to stable" in your bodhi
> update page:
> https://admin.fedoraproject.org/updates/pending/F7/perl-File-chmod-0.32-1.fc7
I can't find any such buttons on this page nor can I find any online help nor
online documentation on this bureaucratic act you want me to execute available.




Comment 7 Jesse Keating 2007-08-06 15:18:47 UTC
You don't see the links because I already did it for you as I stated in my entry.

The documentation on how to use it is at
http://fedoraproject.org/wiki/PackageMaintainers/UpdatingPackageHowTo along with
all the other documentation we're trying to gather for Package Maintainers. 
Hopefully Luke is done with his move and can process some of the feature
requests, like having a help link that leads you to this documentation from
within bodhi itself.

And is it really "bureaucratic" for you to choose whether you want this update
item you created to be pushed to testing or stable?  Come on Ralf, lighten up.

Comment 8 Ralf Corsepius 2007-08-06 15:30:14 UTC
(In reply to comment #7)

> And is it really "bureaucratic" for you to choose whether you want this update
> item you created to be pushed to testing or stable?
Yes, it is. Anything beyond a "make release" or similar as part of the CVS tree
is bureaucratic and insane.

>  Come on Ralf, lighten up.
Stop killing Fedora by implementing more and more bureaucratic hurdles and
forcing us to use unusable web-applications.




Comment 9 Lubomir Rintel 2014-01-21 17:54:16 UTC
Package Change Request
======================
Package Name: perl-File-chmod
New Branches: epel7
Owners: lkundrak

The Fedora maintainer (Ralf Corsepius, corsepiu) is not willing to maintain EPEL packages.

Comment 10 Gwyn Ciesla 2014-01-21 18:06:15 UTC
Git done (by process-git-requests).

Comment 11 Ralf Corsepius 2014-01-21 18:14:02 UTC
(In reply to Lubomir Rintel from comment #9)
> The Fedora maintainer (Ralf Corsepius, corsepiu) is not willing to maintain
> EPEL packages.

This is a misunderstanding: I saying thanks to the fact RH is not providing freely accessible RHEL binary distributions, it's impossible for people who do not have a RHEL-contract (like me) to build, test and maintain EPEL packages.


Note You need to log in before you can comment on or make changes to this bug.