Red Hat Bugzilla – Bug 250468
Review Request: vcmd - A developers interface to the Linux-VServer kernel interface
Last modified: 2008-01-28 16:24:40 EST
Spec URL: http://dev.laptop.org/~coderanger/rpm/vcmd/vcmd.spec SRPM URL: http://dev.laptop.org/~coderanger/rpm/vcmd/vcmd-0.09-1.fc8.src.rpm Description: This is a developers tool to access and work with the VServer kernel interface.
MD5Sum: ef7787845e698017b370923b919ab023 vcmd-0.09.tar.bz2 Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Buildroot has all required elements * All directories are owned by this or other packages * All necessary BuildRequires listed. * Make succeeds even when %{_smp_mflags} is defined * Files have appropriate permissions and owners * Package builds fine in Mock. Bad: * Not all paths use macros. In particular, look at '/usr/sbin/'. refer to http://fedoraproject.org/wiki/Packaging/RPMMacros * rpmlint produces the following errors: W: vcmd no-documentation This error can be ignored, since the tarball contains no documentation. W: vcmd invalid-license GPL This error needs to fixed though. I looked through the tarball, and couldn't find any mention of the license used. Also, if it is actually GPL, we will need to clarify what version according to the new license tag guidelines. refer to http://fedoraproject.org/wiki/Licensing Note: Looks like a newer version of this package is available.
Bumped the version to 0.12, which now includes a COPYING file (which is indeed GPL). Fixed the macros issue too. SRPM: http://dev.laptop.org/~coderanger/rpm/vcmd/vcmd-0.12-1.fc8.src.rpm Spec is in the same place.
Looks pretty good, but the license is still wrong since GPL is no longer valid. Please refer to: http://fedoraproject.org/wiki/Licensing
ping?
This package is not needed for OLPC at this time so we're no longer able to maintain it. If it becomes relevant again, we can reopen the bug. [Anyone else who's interested should feel free to pick this up if they want it!] Anyway, thanks very much for the reviews!