Red Hat Bugzilla – Bug 251611
Review Request: perl-Template-Alloy - TT2/3, HT, HTE, Tmpl, and Velocity Engine
Last modified: 2007-11-30 17:12:12 EST
SRPM URL: http://home.comcast.net/~ckweyl/perl-Template-Alloy-1.006-1.fc6.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-Template-Alloy.spec
"An alloy is a homogeneous mixture of two or more elements"
Template::Alloy represents the mixing of features and capabilities from all
of the major mini-language based template systems (support for
non-mini-language based systems will happen eventually). With Template::Alloy
you can use your favorite template interface and syntax and get features from
each of the other major template systems. And Template::Alloy is fast -
whether you're using mod_perl, cgi, or running from the commandline. There
is even Template::Alloy::XS for getting a little more speed when that is
Updated license tag and to 1.007.
Is this still blocked by the CGI::Ex ticket (which seems to be assigned to you)?
Rather, it's the other way around -- this review is blocking the upgrade ticket :)
Erm, sorry for dumbness.
Looks good to me. The Summary: is terribly cryptic, though. I know it's what
upstream uses as their summary, but perhaps it would be nicer to say something
like "Fast templating engine supporting the syntax of several other templating
systems" except that's too long. Ugh. I'll leave it up to you.
* source files match upstream:
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
? summary is somewhat cryptic.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane; full list at the end.
* %check is present and all tests pass:
All tests successful.
Files=9, Tests=2992, 3 wallclock secs ( 3.14 cusr + 0.28 csys = 3.42 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
Full provides and requires:
perl(Template::Alloy) = 1.007
perl-Template-Alloy = 1.007-1.fc8
New Package CVS Request
Package Name: perl-Template-Alloy
Short Description: TT2/3, HT, HTE, Tmpl, and Velocity Engine
Branches: FC-6 F-7 F-8 devel
(In reply to comment #4)
> Erm, sorry for dumbness.
Hey, that's my line! :)
w.r.t. the summary, I agree. I'm tempted to say "Template::Any by another name"
but I suspect that would be just as confusing to the layman, if slightly less to
Imported and built. Thanks for the review! :)