Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://luk1337.fedorapeople.org/review/rubygem-factory_bot.spec SRPM URL: https://luk1337.fedorapeople.org/review/rubygem-factory_bot-6.6.0-1.fc46.src.rpm Description: Framework and DSL for defining and using model instance factories Fedora Account System Username: luk1337 NOTE: This is a re-review request to unretire the package in rawhide.
Will review. Would you have a time to review my package for swap? https://bugzilla.redhat.com/show_bug.cgi?id=2464119
(In reply to Mamoru TASAKA from comment #1) > Will review. > > Would you have a time to review my package for swap? > https://bugzilla.redhat.com/show_bug.cgi?id=2464119 will do, thanks!
Well: * Not blockers - I don't think ">= 3.0.0" part in "BuildRequires: ruby" is needed. We no longer support such old rubies. - I suggest moving "README.md" to main package: I think the author expects this to be read at first. Please consider above. * spec file clean * license correct * BR / Requires correct * builds successfully https://koji.fedoraproject.org/koji/taskinfo?taskID=149847022 * installation successful * Minimum usablily test works: $ ruby -e "require 'factory_bot' ; puts FactoryBot::VERSION" 6.6.0 ====================================================== This package (rubygem-factory_bot) is APPROVED by mtasaka ======================================================
Thanks, I applied both suggestions.
FEDORA-2026-c0d555fb5d (rubygem-factory_bot-6.6.0-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-c0d555fb5d
FEDORA-2026-95df7746b6 (rubygem-factory_bot-6.6.0-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-95df7746b6
FEDORA-2026-11b5bf2232 (rubygem-factory_bot-6.6.0-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2026-11b5bf2232
FEDORA-2026-95df7746b6 has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-95df7746b6` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-95df7746b6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-11b5bf2232 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-11b5bf2232` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-11b5bf2232 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-c0d555fb5d has been pushed to the Fedora 45 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-c0d555fb5d` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-c0d555fb5d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-c0d555fb5d (rubygem-factory_bot-6.6.0-1.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2026-11b5bf2232 (rubygem-factory_bot-6.6.0-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2026-95df7746b6 (rubygem-factory_bot-6.6.0-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.