Bug 253043 - Review Request: elftoaout - A utility for converting ELF binaries to a.out binaries
Summary: Review Request: elftoaout - A utility for converting ELF binaries to a.out bi...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jima
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 252456
TreeView+ depends on / blocked
 
Reported: 2007-08-16 18:21 UTC by Dennis Gilmore
Modified: 2007-11-30 22:12 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2007-09-25 17:03:36 UTC
Type: ---
Embargoed:
jima: fedora-review+
dennis: fedora-cvs+


Attachments (Terms of Use)

Description Dennis Gilmore 2007-08-16 18:21:11 UTC
Spec URL: http://ausil.us/packages/elftoaout.spec
SRPM URL: http://ausil.us/packages/elftoaout-2.3-8.fc8.src.rpm
Description: 
The elftoaout utility converts a static ELF binary to a static a.out
binary.  If you're using an ELF system (i.e., Fedora) on a SPARC, you'll
need to run elftoaout on the kernel image so that the SPARC PROM can
netboot the image.

If you're installing Fedora on a SPARC, you'll need to install the elftoaout
package.

Comment 1 Dennis Gilmore 2007-08-16 19:15:01 UTC
update from irc comments 
SRPM: http://ausil.us/packages/elftoaout-2.3-9.fc8.src.rpm
SPEC: http://ausil.us/packages/elftoaout.spec

Comment 2 Jima 2007-08-16 19:42:05 UTC
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
be3bd6f7ba8ae107cbdbaa820ba64f86  elftoaout-2.3.tgz
be3bd6f7ba8ae107cbdbaa820ba64f86  elftoaout-2.3.tgz.1
n/a - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane:

Requires:
libc.so.6
libc.so.6(GLIBC_2.0)
libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.1.3)
libc.so.6(GLIBC_2.4)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rtld(GNU_HASH)

Provides:
elftoaout = 2.3-9.fc8


SHOULD Items:

OK - Should build in mock.
See below (#1) - Should build on all supported archs
See below (#2) - Should function as described.
OK - Should have dist tag
OK - Should package latest version
0 bugs - check for outstanding bugs on package.

Notes:
#1: Package is designed for SPARC.  Will it build anywhere else?  Is
there any practical use for it anywhere else?  I won't claim to know.
(However, will we need to file ExclusiveArch bugs?)

#2: As far as I can tell, it works.  It generates the exact same a.out
image as Aurora Corona's elftoaout.  (Not that that's terribly
conclusive...it's a good sign, though.)

I think we're probably good for now.  We might want to look at DaveM's
patch, which is dated 2006-01-03 as opposed to our 2002-06-03-ish patch
(and includes the same and then some), but I don't think it's dire.

I'm calling elftoaout APPROVED.  Pass Go, collect 200 bogomips.

It's amusing to note, by the way, that while this package doesn't have
any open bugs, it does have two closed ones: BZ#446 and BZ#9679.  No,
those numbers aren't typos. :-)

Comment 3 Dennis Gilmore 2007-08-16 20:50:07 UTC
New Package CVS Request
=======================
Package Name: elftoaout
Short Description:  A utility for converting ELF binaries to a.out binaries
Owners: spot, ausil, pjones, jima
Branches: 
InitialCC: 
Commits by cvsextras: yes

Comment 4 Dennis Gilmore 2007-08-16 21:43:38 UTC
cvs done


Note You need to log in before you can comment on or make changes to this bug.