Spec URL: http://rstrode.fedorapeople.org/bluecurve-classic-metacity-theme/checkout/gtk-bluecurve-engine.spec SRPM URL: http://rstrode.fedorapeople.org/bluecurve-classic-metacity-theme/checkout/gtk-bluecurve-engine-1.0.0-1.fc8.src.rpm Description: This package contains the Bluecurve classic metacity theme, a theme that was shipped in late versions of Red Hat Linux and early versions of Fedora Core.
License field is wrong Source URL should be a url or have a comment explaining why not Description is somewhat misleading, we are still shipping it. It is just not the default anymore. find_lang %{name} || touch %{name}.lang Why this construct ? Either there are translations or not... I stopped including Changelog in %doc lists, recently, but thats up to you.
Trimmed the description. the find_lang shortcut, is just because the upstream tarballs don't yet contain translations. At some point in the near future they may.
> At some point in the near future they may. Worth a quick comment, just like the src url still is. Also, what is the strategy wrt to obsoleting redhat-artwork, or conflicting with it ?
Added the comments. I guess I'm going to need to get all the packages that Requires: redhat-artwork updated to require the part they actually need. We may want to add a Provides: redhat-artwork in fedora-gnome-theme since it will pull in most of the content, not sure.
rpmlint is silent package name: ok spec file name: ok package guidelines: ok license: ok license field: ok license file: must be included spec file language: ok spec file legible: yes upstream sources: no upstream yet buildable: ok ExcludeArch: n/a BRs: ok locales: ok shared libs: n/a relocatable: n/a directory ownership: must own /usr/share/themes/Bluecurve-classic and its subdirectory permissions: ok %clean: ok macro use: ok content: permissible large docs: n/a %doc: ok headers: n/a static libs: n/a pc files: n/a library symlinks: n/a devel package: n/a la files: ok gui apps: n/a directory ownership: ok %install: ok utf8 filenames: ok include the license file and fix the directory ownership, then it is good to go.
should be good to go
indeed, approved
New Package CVS Request ======================= Package Name: bluecurve-classic-metacity-theme Short Description: Bluecurve-classic-metacity-theme Owners: rstrode,davidz Branches: InitialCC: Cvsextras Commits: no
done