Bug 305621 - Review Request: bluecurve-metacity-theme - Bluecurve metacity theme
Summary: Review Request: bluecurve-metacity-theme - Bluecurve metacity theme
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Matthias Clasen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks: ArtworkSplit
TreeView+ depends on / blocked
 
Reported: 2007-09-25 17:23 UTC by Ray Strode [halfline]
Modified: 2007-11-30 22:12 UTC (History)
2 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2007-10-11 15:59:46 UTC
mclasen: fedora-review+
notting: fedora-cvs+


Attachments (Terms of Use)

Description Ray Strode [halfline] 2007-09-25 17:23:21 UTC
Spec URL:
http://rstrode.fedorapeople.org/bluecurve-metacity-theme/checkout/bluecurve-metacity-theme.spec

SRPM URL:
http://rstrode.fedorapeople.org/bluecurve-metacity-theme/checkout/bluecurve-metacity-theme-1.0.0-1.fc8.src.rpm

Description:
This package contains the Bluecurve metacity theme, a modernization of
the Bluecurve classic theme, that was shipped in late versions of
Red Hat Linux and early versions of Fedora Core.

Comment 1 Matthias Clasen 2007-09-26 03:54:06 UTC
rpmlint output: 
[mclasen@localhost Desktop]$ rpmlint
/var/lib/mock/fedora-development-i386/result/bluecurve-metacity-theme-1.0.0-1.fc8.noarch.rpm

bluecurve-metacity-theme.noarch: W: invalid-license GPL

package name: ok
spec file name: ok
packaging guidelines: ok
license: ok
license field: invalid
license file: ok
spec file language: AE
spec file readability: excellent
upstream sources: no upstream yet
buildability: ok
ExcludeArch: n/a
BRs: ok
locales: ok
shared libs: n/a
relocatable: n/a
directory ownership: who is supposed to own 
  /usr/share/themes/Bluecurve in the new regime ?
%files: ok
permissions: ok
%clean: ok
macro use: consistent
content: permissible
large docs: n/a
%doc: ok
headers: n/a
static libs: n/a
pc files: n/a
shared libs: n/a
devel package: n/a
libtool archives: ok
gui apps: n/a
directory ownership: see above
%install: ok
utf8 filenames: ok

Further comments: 
%description is misleading, since we are to this day shipping Bluecurve.

Comment 2 Ray Strode [halfline] 2007-09-26 04:02:41 UTC
fixed.  I'm going to need to do another one

bluecurve-gnome-theme 

to cover the directory ownership (and old the meta theme file).  It fell through
the cracks when I did the split up.

Comment 3 Matthias Clasen 2007-09-26 16:03:02 UTC
but then you need to make this package require bluecurve-gnome-theme ?

Comment 4 Ray Strode [halfline] 2007-09-26 17:09:52 UTC
i don't know, aside from the dir ownership issue, it makes more sense for
bluecurve-gnome-theme to require bluecurve-metacity-theme, not the other way
around...

Comment 5 Ray Strode [halfline] 2007-09-27 14:38:17 UTC
So I talked to Matthias about this a bit today.  The consensus is we'll have all
the theme packages own /usr/share/themes/Bluecurve.

We think that's probably better than a circular dependency or
bluecurve-filesystem...

Comment 6 Matthias Clasen 2007-09-27 18:31:56 UTC
Approved

Comment 7 Ray Strode [halfline] 2007-10-09 16:02:06 UTC
New Package CVS Request
=======================
Package Name: bluecurve-metacity-theme
Short Description: Bluecurve Metacity theme
Owners: rstrode,davidz
Branches:
InitialCC:
Cvsextras Commits: no

Comment 8 Bill Nottingham 2007-10-09 21:32:54 UTC
done


Note You need to log in before you can comment on or make changes to this bug.