Bug 305631 - Review Request: bluecurve-qt-engine - Bluecurve qt engine
Summary: Review Request: bluecurve-qt-engine - Bluecurve qt engine
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Matthias Clasen
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: ArtworkSplit
TreeView+ depends on / blocked
Reported: 2007-09-25 17:26 UTC by Ray Strode [halfline]
Modified: 2007-11-30 22:12 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2007-09-28 21:25:14 UTC
Type: ---
mclasen: fedora-review+

Attachments (Terms of Use)

Comment 2 Ray Strode [halfline] 2007-09-25 18:09:31 UTC
woops, thanks for catching that.

Comment 3 Matthias Clasen 2007-09-26 04:49:02 UTC
rpmlint output:
[mclasen@localhost Desktop]$ rpmlint
bluecurve-qt-engine.i386: W: invalid-license LGPL
bluecurve-qt-engine.src: W: invalid-license LGPL
bluecurve-qt-engine-debuginfo.i386: W: invalid-license LGPL

package name: ok
spec file name: ok
packaging guidelines: ok
license: ok
license field: invalid
license file: ok
spec language: AE
spec readability: excellent
upstream sources: no upstream yet
buildability: ok
ExcludeArch: n/a
BRs: configure looks for KDE headers, so needs to BR kdebase-devel
locales: ok
shared libs: ok
relocatable: n/a
directory ownership: /usr/lib/gt-3.3/plugins/styles is owned by 
  redhat-artwork-kde, so you should probably require that. Ir is that going
  to be cut into pieces, too ?
%files: ok
permissions: ok
%clean: ok
macro use: consistent
content: permissible
large docs: n/a
%doc: ok
headers: n/a
static libs: n/a
pc files: n/a
shared libs: n/a
devel package: n/a
libtool archives: ok
gui apps: n/a
directory ownership: ok
%install: ok
utf8 filenames: ok

Comment 4 Ray Strode [halfline] 2007-09-26 05:18:34 UTC
changed license to LGPLv2, added build requires

I don't think redhat-artwork-kde should own that directory--qt should, yea?

Comment 5 Kevin Kofler 2007-09-26 11:21:53 UTC
Is the BR kdebase-devel actually needed here? I think it isn't, it's needed 
only for the KWin theme, which isn't part of this package.

Comment 6 Matthias Clasen 2007-09-26 16:04:41 UTC
the configure script complains if it is not there...

Comment 7 Ray Strode [halfline] 2007-09-27 14:21:25 UTC
Filed bug 309091 for the qt issue

Comment 8 Matthias Clasen 2007-09-27 18:33:15 UTC

Comment 9 Ray Strode [halfline] 2007-09-28 21:25:14 UTC
we're going to merge this one into bluecurve-kde-theme

Note You need to log in before you can comment on or make changes to this bug.