Spec URL: http://rstrode.fedorapeople.org/fedora-icon-theme/checkout/fedora-icon-theme.spec SRPM URL: http://rstrode.fedorapeople.org/fedora-icon-theme/checkout/fedora-icon-theme-1.0.0-1.fc8.src.rpm Description: This package contains the Fedora icon theme.
MUST items: - Package meets naming and packaging guidelines - OK - Spec file matches base package name. - OK - Spec has consistant macro usage. - OK - Meets Packaging Guidelines. - OK - License - OK - License field in spec matches - *** Should be GPL+. Of course, not much copyrightable here. - License file included in package - OK - Spec in American English - OK - Spec is legible. - OK - BuildRequires correct - *** Needs perl(XML::Parser) - Spec handles locales/find_lang - OK - Package has %defattr and permissions on files is good. - OK - Package has a correct %clean section. - OK - Package has correct buildroot - OK - Package is code or permissible content. - OK - Packages %doc files don't affect runtime. - OK - Package compiles and builds on at least one arch - tested x86_64 - Package has no duplicate files in %files. - OK - Package doesn't own any directories other packages own. - OK - Package owns all the directories it creates. - OK - No rpmlint output. - *** fedora-icon-theme.noarch: E: zero-length /usr/share/doc/fedora-icon-theme-1.0.0/NEWS fedora-icon-theme.noarch: E: zero-length /usr/share/doc/fedora-icon-theme-1.0.0/ChangeLog fedora-icon-theme.noarch: E: zero-length /usr/share/doc/fedora-icon-theme-1.0.0/README Can be removed. fedora-icon-theme.noarch: W: invalid-license GPL See above. - final provides and requires are sane: I don't see any reason why this requires system-logos. What it probably should require is mist-icon-theme or gnome-icon-theme, as that's what it inherits from. Should probably provide system-icon-theme, as well. SHOULD Items: - Should build in mock. - See above about buildreqs - Should function as described. - didn't test - Should have sane scriptlets. - OK - Should have dist tag - OK
should be fixed up now
Still would like Provides: system-icon-theme
woops, sorry, doing too many things at once, should be good to go now.
Looks good. Approved.
New Package CVS Request ======================= Package Name: fedora-icon-theme Short Description: fedora icon theme Owners: rstrode,davidz Branches: InitialCC: Cvsextras Commits: no
done