Bug 313981 - gnome-password-generator requires redhat-artwork
Summary: gnome-password-generator requires redhat-artwork
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-password-generator
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Debarshi Ray
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: ArtworkSplit
TreeView+ depends on / blocked
 
Reported: 2007-10-01 15:16 UTC by Ray Strode [halfline]
Modified: 2007-12-10 20:44 UTC (History)
0 users

Fixed In Version: 1.5-2.fc7
Clone Of:
Environment:
Last Closed: 2007-12-10 20:44:31 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Ray Strode [halfline] 2007-10-01 15:16:10 UTC
Hi,

I'm trying to get rid of redhat-artwork (see bug 305441).  

Do you know what gnome-password-generator needs redhat-artwork for?

Could you change the requires to one or more of:

bluecurve-classic-metacity-theme
bluecurve-gdm-theme
bluecurve-gnome-theme
bluecurve-gtk-themes
bluecurve-icon-theme
bluecurve-metacity-theme
bluecurve-xmms-skin
fedorabubbles-gdm-theme
fedoradna-gdm-theme
fedoraflyinghigh-gdm-theme
fedora-gnome-theme
fedora-icon-theme
gtk-bluecurve-engine

?

Comment 1 Debarshi Ray 2007-10-02 20:18:45 UTC
It uses redhat-artwork for the following portion of the code:

   102          menu_items = (
   103              ("/_File", None, None, 0, "<Branch>"),
   104              ("/File/_Quit", "<control>Q", self.DestroyCallback, 0,
"<StockItem>", gtk.STOCK_QUIT),
   105              ("/_Help", None, None, 0, "<Branch>"),
   106              ("/_Help/_About", None, self.AboutCallback, 0,
"<StockItem>", "gnome-stock-about")
   107          )

Reference:
https://bugzilla.redhat.com/show_bug.cgi?id=245649

As far as I understand, redhat-artwork should be replaced by either
fedora-gnome-theme or fedora-icon-theme. Which one should I pick?

Comment 2 Ray Strode [halfline] 2007-10-02 20:50:12 UTC
i'd just use gtk.STOCK_ABOUT there and drop the dep entirely (eventually you may
want to port to UI manager btw)

Comment 3 Ray Strode [halfline] 2007-10-02 20:51:15 UTC
so just to be clear, I'd drop the Requires: redhat-artwork from the spec file
and change the occurrence of "gnome-stock-about" to gtk.STOCK_ABOUT

Comment 4 Debarshi Ray 2007-10-03 06:57:54 UTC
Sure. I will update the package after pointing upstream to this issue.

Comment 5 Debarshi Ray 2007-10-06 13:07:57 UTC
This should be fixed in devel now. I am requesting a push to updates-testing for
F-7.

Please confirm so that this bug can be closed.

Comment 6 Ray Strode [halfline] 2007-10-09 15:03:56 UTC
confirmed, Requires: redhat-artwork is no longer in rawhide.

We don't really need to update F-7.  It's not going to be changed

Comment 7 Fedora Update System 2007-10-11 22:52:22 UTC
gnome-password-generator-1.5-2.fc7 has been pushed to the Fedora 7 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update gnome-password-generator'

Comment 8 Fedora Update System 2007-12-10 20:44:29 UTC
gnome-password-generator-1.5-2.fc7 has been pushed to the Fedora 7 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.