Red Hat Bugzilla – Bug 315351
Review Request: superiotool - Simple program for detecting Super I/O on your mainboard
Last modified: 2007-11-30 17:12:17 EST
Spec URL: http://peter.fedorapeople.org/superiotool.spec
SRPM URL: http://peter.fedorapeople.org/superiotool-0-0.1.20071002svn2816.fc7.src.rpm
Description: User-space helper tool which allows you to detect which Super I/O you have
on your mainboard, and it can provide detailed information about the register
contents of the Super I/O.
A small companion to flashrom but more highly tailored for developer's specific tasks. Easy to review though
Need some changes
1) Preserve timestamp by using -p option
2) patch name should be superiotool-Makefile_cleanup.diff
Remove extra hypen in patch name and apply patch in %setup as
%patch -p0 -b .Makefile_cleanup
3) SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
4) either use macros for all commands install,mkdir or remove macro use for rm,
(In reply to comment #1)
> Need some changes
> 1) Preserve timestamp by using -p option
> 2) patch name should be superiotool-Makefile_cleanup.diff
> Remove extra hypen in patch name and apply patch in %setup as
> %patch -p0 -b .Makefile_cleanup
> 3) SHOULD: If the source package does not include license text(s) as a separate
> file from upstream, the packager SHOULD query upstream to include it.
I'll drop a line to linuxbios-maillist later.
> 4) either use macros for all commands install,mkdir or remove macro use for rm,
> mkdir commands.
New svn. version 2818 (slightly changed output of ./superiotool -v command)
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and RPM.
+ source files match upstream.
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package in source files.
+ %doc files present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ package superiotool-0-0.2.20071003svn2818.fc8 ->
Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.3.4)
+ Not a GUI app.
You missed to remove make command macro. make sure to take care of that at
time of cvs import.
New Package CVS Request
Package Name: superiotool
Short Description: Simple program for detecting Super I/O on your mainboard
Branches: FC-6 F-7 EL-4 EL-5
Cvsextras Commits: yes