Red Hat Bugzilla – Bug 322141
Review Request: egoboo-data - Data files for the Egoboo RPG
Last modified: 2007-11-30 17:12:17 EST
Spec URL: http://people.atrpms.net/~hdegoede/egoboo-data.spec
SRPM URL: http://people.atrpms.net/~hdegoede/egoboo-data-2.4.3-1.fc8.src.rpm
Data files for the Egoboo RPG.
egoboo itself is review bug 322161
OK source files match upstream (used instructions from the spec file, no diff
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
OK license field matches the actual license (GPL).
OK license is open source-compatible. License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK %clean is present.
OK package builds in mock (development/i386).
OK rpmlint is silent.
OK final provides and requires look sane.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK scriptlets are present.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
This package is APPROVED. But clarify the GPL version with upstream.
Thanks! I've send a mail to upstream to clarify the license version.
New Package CVS Request
Package Name: egoboo-data
Short Description: Data files for the Egoboo RPG
Branches: F-7 devel
Cvsextras Commits: Yes
Imported and build, closing.
Note F-7 update pushing is waiting for enet tagging into F-7 buildroot so that
egoboo can be build and this can be pushed as an update bundle.