Red Hat Bugzilla – Bug 327351
Review Request: python-alsa - Python binding for the ALSA library
Last modified: 2007-11-30 17:12:18 EST
Spec URL: ftp://toaster.asplinux.com.ua/pub/people/andy/extras/python-alsa.spec
SRPM URL: ftp://toaster.asplinux.com.ua/pub/people/andy/extras/python-alsa-
Python binding for the ALSA library.
There is native binding to ALSA is developed by ALSA team.
1)Good to add test directory to %doc
2) Also, I think good to use only LGPLv2 as __init__.py lacks copyright code.
whereas I have seen few packages installed on my system which have copyright in
__init__.py evenif its empty code.
1. I was thinking about it. And I almost agree with you.
2. __init__.py is quite empty. I think the License tag should derived from the
real code. Anyway, I'll write to Jaroslav about this misspelling (and I save
License tag while now).
you miss to add following line to %prep
chmod -x test/*
(In reply to comment #3)
Oh, my mistake, sorry. Now fixed.
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags are honoured correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Package python-alsa-1.0.15-0.3.rc2.fc8 ->
Provides: alsacard.so alsacontrol.so alsahcontrol.so alsamixer.so
Requires: libasound.so.2 libasound.so.2(ALSA_0.9) libasound.so.2(ALSA_0.9.3)
libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.4)
libpthread.so.0 libpython2.5.so.1.0 python(abi) = 2.5 rtld(GNU_HASH)
+ Not a GUI app.
Thank you for review.
heh. How can this review request be completed?
Don't you want to build package? create CVS module?
I wonder howcome this package will appear in CVS/rawhide?
Please check http://fedoraproject.org/wiki/PackageMaintainers/NewPackageProcess .
Next you have to do "CVSAdminProcedure".
New Package CVS Request
Package Name: python-alsa
Short Description: Python binding for the ALSA library
Cvsextras Commits: yes
(In reply to comment #7)
Real closed request ticket.
python-alsa-1.0.14-1.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
su -c 'yum --enablerepo=updates-testing update python-alsa'
python-alsa-1.0.14-1.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request
Package Name: python-alsa
New Branches: EL-5