Red Hat Bugzilla – Bug 328951
Review Request: kacst-fonts - Fonts for arabic from arabeyes project
Last modified: 2007-11-30 17:12:18 EST
Spec URL: <http://rbhalera.fedorapeople.org/kacst-fonts/kacst-fonts.spec> SRPM URL: <http://rbhalera.fedorapeople.org/kacst-fonts/kacst-fonts-1.6.2-1.fc8.src.rpm> Description: This package contains fonts for the display of Arabic from the King Abdulaziz City for Science & Technology(kacst).
rpmlint on rpm gave me kacst-fonts.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/kacst-fonts-1.6.2/LICENSE.TXT Add following in SPEC BuildRequires: dos2unix find . -not -name \*.ttf -type f -exec dos2unix -k {} \;
Updated. Spec URL: <http://rbhalera.fedorapeople.org/kacst-fonts/kacst-fonts.spec> SRPM URL: <http://rbhalera.fedorapeople.org/kacst-fonts/kacst-fonts-1.6.2-2.fc8.src.rpm>
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 3f914b65dc4e0cc7b30e1d6b263f1d16 kacst_fonts_1.6.2.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + fonts scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI App. APPROVED.
New Package CVS Request ======================= Package Name: kacst-fonts Short Description: Fonts for arabic from arabeyes project Owners: rbhalera Branches: devel InitialCC: petersen Cvsextras Commits: yes
cvs done.