Spec URL: http://www.diffingo.com/downloads/diffingo-repo/PySolFC-cardsets.spec SRPM URL: http://www.diffingo.com/downloads/diffingo-repo/PySolFC-cardsets-1.1-1.fc8.src.rpm Description: This package contains various cardsets for pysol
Builds OK; rpmlint says: PySolFC-cardsets.noarch: W: no-documentation No problem. PySolFC-cardsets.noarch: E: script-without-shebang /usr/share/PySolFC/data/cardset-hannover-court/COPYRIGHT PySolFC-cardsets.noarch: E: script-without-shebang /usr/share/PySolFC/data/cardset-hannover-hex/COPYRIGHT These are executable for some reason, and probably shouldn't be. They're the only two executable files in the package. I think the URL: tag should be http://pysolfc.sourceforge.net/ You can get rid of the python_sitelib and debug_package defines at the top of the spec. I also don't see the reason for the build dependency on python-devel when the only thing this package does is copy a directory. There seems to be a directory ownership problem; nothing seems to own /usr/share/PySolFC/data. The base PySolFC package just puts the base cardsets in /usr/share/PySolFC. You probably want to change the Summary and %description to mention PySolFC instead of pysol (and tack a period onto the end of %description while you're in there). You can do that thing without using the dist tag if you like.
Fixed - New URLs: Spec URL: http://www.diffingo.com/downloads/diffingo-repo/PySolFC-cardsets.spec SRPM URL: http://www.diffingo.com/downloads/diffingo-repo/PySolFC-cardsets-1.1-2.fc8.src.rpm
I think you meant http://www.diffingo.com/downloads/diffingo-repo/PySolFC-cardsets-1.1-2.src.rpm (no ".fc8") It occurs to me that the reason I couldn't download the source is because the Source0: URL is incorrect. I found that http://downloads.sourceforge.net/pysolfc/PySolFC-Cardsets-1.1.tar.bz2 works fine. I still don't get why python-devel is needed to build this; I built both with and without it and the resulting package is the same. Unfortunately, that package doesn't actually seem to do anything when I install it. Pysol shows the same cardsets whether this package is installed or not. However, I moved everything from /usr/share/PySolFC/data one directory up and the cardsets were found. However, there are some directories both in this package and in the base PySolFC package that contain the same data: cardset-2000 cardset-crystal-mahjongg cardset-dashavatara-ganjifa cardset-dondorf cardset-gnome-mahjongg-1 cardset-hexadeck cardset-kintengu cardset-matrix cardset-mughal-ganjifa cardset-oxymoron cardset-standard cardset-tuxedo cardset-vienna-2k I'm not sure there's any point in packaging them. So I guess either PySolFC needs a patch to look in the "data" directory for cardsets or this package needs to install into %{_datadir}/PySolFC Oh, yeah, and %description lacks a trailing period.
All fixed in release 3: http://www.diffingo.com/downloads/diffingo-repo/PySolFC-cardsets-1.1-3.src.rpm I double-checked the link this time ;)
OK, back from vacation and caught up with life. Now, to this review: Looks much better; the issues I had are fixed. rpmlint says only: PySolFC-cardsets.noarch: W: no-documentation which is OK. * source files match upstream: ae3ff94b50453c15aba07fc6fac9294e6f746d02746a77fe9eefa99864a07e28 PySolFC-Cardsets-1.1.tar.bz2 * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper (none). * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint has acceptable complaints. * final provides and requires are sane: PySolFC-cardsets = 1.1-3 = PySolFC = 1.1 * Manual testing shows things to work fine. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * acceptable content. APPROVED
New Package CVS Request ======================= Package Name: PySolFC-cardsets Short Description: Various cardsets for PySolFC Owners: firewing Branches: F-7 F-8 FC-6 InitialCC: firewing Cvsextras Commits: yes
CVS done.
PySolFC-cardsets-1.1-3.2 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.