Red Hat Bugzilla – Bug 35362
SRPM patches a dynamically generated file = bad
Last modified: 2007-04-18 12:32:37 EDT
I cannot build ntp-4.0.99k-15 from the SRPM as config.h is patched after
running the configuration script.
+ patch config.h
patching file `config.h'
Hunk #1 FAILED at 466.
Hunk #2 FAILED at 808.
Ugh. Yes, using patch is quick and easy, and works most of the time. No,
you shouldn't use patch on dynamically generated files.
Also, I took this (detecting time.h right) up with ntp developers a month or so ago. Should be fixed
for the next release.
Meanwhile, here's a fix: The offending patch is just trying to #undef 3 constants, so instead of patching, append #undefs:
< Patch0: ntp-4.0.99j-glibc22.patch
> Patch0: ntp-4.0.99j-glibc22.append
< patch config.h < %PATCH0
> cat %PATCH0 >> config.h
/* append to config.h */
BTW, bug 32803 should be marked as a duplicate of this bug. (In that bug, the patch is effectively a no-op because these syms are already undefined
for the old glibc.)
will be in 4.0.99mrc2-4 and newer packages