Red Hat Bugzilla – Bug 382761
Review Request: python-cerealizer - Secure pickle-like module
Last modified: 2007-11-30 17:12:22 EST
Spec URL: http://www.auroralinux.org/people/spot/review/new/python-cerealizer.spec
SRPM URL: http://www.auroralinux.org/people/spot/review/new/python-cerealizer-0.6-1.fc9.src.rpm
Cerealizer is a secure pickle-like module. It support basic types (int, string,
unicode, tuple, list, dict, set,...), old and new-style classes (you need to
register the class for security), object cycles, and it can be extended to
support C-defined type.
Builds fine, rpmlint is clean. Not really much here, honestly. The only
comment I can make is that there's a test suite, but I can't get it to run in
the context of the build. I'm sure a python wizard could make it work, but I'm
not one. Hmm, wait:
Ran 46 tests in 0.009s
So I guess you could do that, but no big deal.
* source files match upstream:
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
python-cerealizer = 0.6-1.fc9
python(abi) = 2.5
? %check is not present, but it could be added. It runs fine.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
CVS done, builds building. Thanks for the review. :)