Red Hat Bugzilla – Bug 397811
Review Request: zaf - south african hyphenation rules
Last modified: 2007-11-30 17:12:23 EST
Spec URL: http://people.redhat.com/caolanm/hyphen/zaf.spec SRPM URL: http://people.redhat.com/caolanm/hyphen/zaf-0-0.1.20071123svn.fc9.src.rpm Description: hyphenation rules for "hyphen" as used for OOo for breaking lines for South African languages, i.e. currently Afrikaans and Zulu
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream. a48563663dcaf5d924a28bf323b3d511 zaf-0-0.1.20071123svn.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains contents. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. APPROVED.
New Package CVS Request ======================= Package Name: zaf Short Description: hyphenation rules for "hyphen" as used for OOo for breaking lines Owners: caolanm@redhat.com Branches: devel Cvsextras Commits: yes
caolanm->panemade: Thanks a lot for the block of reviews, nice to get them through together. I appreciate the work. I've only 397741 left of my 10 hyphenation packages, *hint* :-)
cvs done.
built