Bug 405171 - Review Request: CriticalMass - SDL/OpenGL space shoot'em up game also known as critter
Summary: Review Request: CriticalMass - SDL/OpenGL space shoot'em up game also known a...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Patrice Dumas
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 407571
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-11-29 21:58 UTC by Hans de Goede
Modified: 2007-12-18 09:11 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2007-12-18 09:11:42 UTC
Type: ---
Embargoed:
pertusus: fedora-review+
tcallawa: fedora-cvs+


Attachments (Terms of Use)

Description Hans de Goede 2007-11-29 21:58:12 UTC
Spec URL: http://people.atrpms.net/~hdegoede/CriticalMass.spec
SRPM URL: http://people.atrpms.net/~hdegoede/CriticalMass-1.0.2-1.fc9.src.rpm
Description:
Critical Mass (aka Critter) is an SDL/OpenGL space shoot'em up game. Your
world has been infested by an aggressive army of space critters. Overrun and   
unprepared, your government was unable to defend its precious resources. As
a last effort to recapture some of the "goodies", you have been placed into
a tiny spacecraft and sent after them.

Comment 1 Patrice Dumas 2007-11-29 22:46:44 UTC
tinyxml should be packaged separately.

The source timestamp isn't kept:
-rw-rw-r-- 1 dumas dumas 5122126 jui 16  2006 CriticalMass-1.0.2.tar.bz2
-rw-rw-r-- 1 dumas dumas 5122126 nov 29 21:41 ../SOURCES/CriticalMass-1.0.2.tar.bz2

I suggest using wget -N or spectool -g or the corresponding curl
option to get the file.

I suggest using
%{_mandir}/man6/critter.6*

Comment 2 Hans de Goede 2007-12-01 22:41:36 UTC
Thanks for the input, all fixed, here is a new version:
Spec URL: http://people.atrpms.net/~hdegoede/CriticalMass.spec
SRPM URL: http://people.atrpms.net/~hdegoede/CriticalMass-1.0.2-2.fc9.src.rpm

See bug 407571 for the tinyxml review

Comment 3 Patrice Dumas 2007-12-17 09:15:00 UTC
* rpmlint says (ignorable)
CriticalMass.i386: W: dangling-relative-symlink /usr/bin/critter-wrapper
opengl-game-wrapper.sh
* follow packaging guidelines 
* free software, license included
* match upstream
e2aff114bffa717fb79c82e1dc473ebe  CriticalMass-1.0.2.tar.bz2
* %files section right

APPROVED

Comment 4 Hans de Goede 2007-12-17 09:52:37 UTC
Thanks for the review!

New Package CVS Request
=======================
Package Name:      CriticalMass
Short Description: SDL/OpenGL space shoot'em up game also known as critter
Owners:            jwrdegoede
Branches:          F-7 F-8 devel
InitialCC:         <empty>
Cvsextras Commits: yes




Comment 5 Tom "spot" Callaway 2007-12-17 16:16:05 UTC
cvs done.

Comment 6 Hans de Goede 2007-12-18 09:11:42 UTC
Imported and build for devel, I will build and push it as an update for F-7 and
F-8 as soon as tinyxml becomes available in the F-7 and F-8 buildroots.



Note You need to log in before you can comment on or make changes to this bug.