Red Hat Bugzilla – Bug 414191
Review Request: oniguruma - Regular expressions library
Last modified: 2014-12-01 08:08:55 EST
Spec URL: http://mtasaka.fedorapeople.org/Review_request/oniguruma/oniguruma.spec
SRPM URL: http://mtasaka.fedorapeople.org/Review_request/oniguruma/oniguruma-5.9.0-1.fc8.src.rpm
Oniguruma is a regular expressions library.
The characteristics of this library is that different character encoding
for every regular expression object can be specified.
(supported APIs: GNU regex, POSIX and Oniguruma native)
koji scratch build for dist-f8-updates-candidate is here.
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ Compiler flags used correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no static libraries.
+ no .pc file present.
+ -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ ldconfig scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package oniguruma-5.9.0-1.fc9 ->
Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3)
libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libonig.so.2 rtld(GNU_HASH)
+ Package oniguruma-devel-5.9.0-1.fc9 ->
Requires: /bin/sh libonig.so.2 oniguruma = 5.9.0-1.fc9
+ Not a GUI App.
New Package CVS Request
Package Name: oniguruma
Short Description: Regular expressions library
Branches: F-8 F-7
Cvsextras Commits: yes
Rebuilt on all branches, requested on bodhi, closing.
Thank you for your review!
Package Change Request
Package Name: oniguruma
New Branches: epel7
Owners: ktdreyer no1youknowz
Paul had contacted Mamoru via private email regarding oniguruma a while back. As discussed in #epel today, I will be co-maintaining oniguruma with Paul (no1youknowz) in EPEL 7 and helping him through the packaging process. I'm sponsoring him through the "co-maintain to sponsor" process (https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group#Become_a_co-maintainer)
Git done (by process-git-requests).