Spec URL: http://mtasaka.fedorapeople.org/Review_request/mfiler2/mfiler2.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/mfiler2/mfiler2-3.2.3-1.fc8.src.rpm Description: Minnu's Filer2 is a two pane file manager under UNIX console. This bug depends on oniguruma (bug 414191) and wkf (bug 414201)
Created attachment 279841 [details] mock build of mfiler2 on rawhide, i386 As this package depends on two packages which are still under review, currently koji scratch build cannot be done. Mock build is successful on rawhide, i386.
Review request on oniguma and wkf finished. Now mfiler2 builds on koji, dist-f9. http://mtasaka.fedorapeople.org/Review_request/mfiler2/mfiler2.spec http://mtasaka.fedorapeople.org/Review_request/mfiler2/mfiler2-3.2.3-2.fc8.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=282794 ------------------------------------------------- * Sat Dec 8 2007 Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> - 3.2.3-2 - Add missing CFLAGS
I'll try to review this later today for you.
Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Buildroot has all required elements * All paths begin with macros * Files have appropriate permissions and owners * Valid license tag * Package builds. http://koji.fedoraproject.org/koji/taskinfo?taskID=282794 * Package requires ruby & ruby abi version. rpmlint produces only the following warning which can be ignored: mfiler2-mdnd.x86_64: W: no-documentation +1 APPROVE
Thank you! New Package CVS Request ======================= Package Name: mfiler2 Short Description: Two pane file manager under UNIX console Owners: mtasaka Branches: F-8 F-7 InitialCC: Cvsextras Commits: yes
cvs done.
Rebuilt on dist-f9, closing (Rebuild on F-8/7 is not done yet because BuildRequires packages are not in buildroot yet). Thank you for your review!