Spec URL: http://labs.linuxnetz.de/bugzilla/gkrellm-top.spec SRPM URL: http://labs.linuxnetz.de/bugzilla/gkrellm-top-2.2.10-1.src.rpm Description: A GKrellM plugin which displays the top three CPU intensive processes in a small window inside GKrellM, similar to wmtop. Useful to check out anytime what processes are consuming most CPU power on your machine.
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. 9699f4068a63202643b15a75232e69d8 gkrelltop_2.2.10.orig.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. - License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honored correctly. + defattr usage is correct but good to have it as defattr(-,root,root,-) + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Package gkrellm-top-2.2.10-1.fc9 Provides: gkrelltop.so gkrelltopd.so Requires: gkrellm >= 2.2.0 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libglib-2.0.so.0 APPROVED.
New Package CVS Request ======================= Package Name: gkrellm-top Short Description: GKrellM plugin which shows 3 most CPU intensive processes Owners: robert Branches: F-7 F-8 EL-4 EL-5 InitialCC: Cvsextras Commits: no
cvs done.
37407 (gkrellm-top): Build on target fedora-5-epel succeeded. Package: gkrellm-top-2.2.10-1.fc7 Tag: dist-fc7-updates-candidate Status: complete Package: gkrellm-top-2.2.10-1.fc8 Tag: dist-f8-updates-candidate Status: complete Package: gkrellm-top-2.2.10-1.fc9 Tag: dist-f9 Status: complete
Package already built for all requested branches. Therefore, closing this review now.
EL-4 was not build, because of the dependency.
ohh. I missed to check that. If you want to keep this review open feel free to reopen this.