Spec URL: http://stahnma.fedorapeople.org/reviews/python-libgmail.spec SRPM URL: http://stahnma.fedorapeople.org/reviews/python-libgmail-0.1.8-1.fc8.src.rpm Description: Library to provide access to Gmail via Python.
Nice to see new python build created egginfo file here. Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. 58f694ae19733e68b97e7a54d96d2637 libgmail-0.1.8.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present which are small. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. APPROVED.
License should be GPLv2, not GPLv2+. $ grep License libgmail.py # License: GPL 2.0
I thought I read through the license file, COPYING and got that, but I could be wrong. Change Made. Latest Copies at Spec URL: http://stahnma.fedorapeople.org/reviews/python-libgmail.spec SRPM URL: http://stahnma.fedorapeople.org/reviews/python-libgmail-0.1.8-2.fc8.src.rpm
(In reply to comment #2) > License should be GPLv2, not GPLv2+. > > $ grep License libgmail.py > # License: GPL 2.0 oops. you are right. missed that libgmail.py clearly said its GPLv2. (In reply to comment #3) > I thought I read through the license file, COPYING and got that, but I could be > wrong. Change Made. > > Latest Copies at > > Spec URL: http://stahnma.fedorapeople.org/reviews/python-libgmail.spec > SRPM URL: > http://stahnma.fedorapeople.org/reviews/python-libgmail-0.1.8-2.fc8.src.rpm Thanks. License looks correct now. APPROVED.
New Package CVS Request ======================= Package Name: python-libgmail Short Description: Library to provide access to Gmail via Python. Owners: mastahnke Branches: EL-4, EL-5, F7 , F8 InitialCC: Cvsextras Commits: yes
Please use Fedora Account name for the Owners field. cvs done.
Michael, Can you build this package so that I can review fuse-gmailfs?
python-libgmail-0.1.8-2.fc7 has been submitted as an update for Fedora 7
python-libgmail-0.1.8-2.fc8 has been submitted as an update for Fedora 8
python-libgmail-0.1.8-2.fc8 has been pushed to the Fedora 8 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-libgmail'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F8/FEDORA-2008-1133
Closing this as this package has been successfully built for all requested branches on build server.
python-libgmail-0.1.8-2.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.
python-libgmail-0.1.8-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.