Bug 422831 - Review Request: python-libgmail - Library to provide access to Gmail via Python
Summary: Review Request: python-libgmail - Library to provide access to Gmail via Python
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 422841 422851
TreeView+ depends on / blocked
 
Reported: 2007-12-13 04:05 UTC by Michael Stahnke
Modified: 2008-02-13 05:16 UTC (History)
2 users (show)

Fixed In Version: 0.1.8-2.fc7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-02-13 05:11:38 UTC
Type: ---
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Michael Stahnke 2007-12-13 04:05:58 UTC
Spec URL: http://stahnma.fedorapeople.org/reviews/python-libgmail.spec
SRPM URL: http://stahnma.fedorapeople.org/reviews/python-libgmail-0.1.8-1.fc8.src.rpm
Description: Library to provide access to Gmail via Python.

Comment 1 Parag AN(पराग) 2007-12-13 05:39:23 UTC
Nice to see new python build created egginfo file here.

Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and RPM.
+ source files match upstream.
58f694ae19733e68b97e7a54d96d2637  libgmail-0.1.8.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present which are small.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.

APPROVED.


Comment 2 Ville Skyttä 2007-12-13 16:52:31 UTC
License should be GPLv2, not GPLv2+.

$ grep License libgmail.py
# License: GPL 2.0

Comment 3 Michael Stahnke 2007-12-13 20:19:11 UTC
I thought I read through the license file, COPYING and got that, but I could be
wrong.  Change Made.

Latest Copies at

Spec URL: http://stahnma.fedorapeople.org/reviews/python-libgmail.spec
SRPM URL:
http://stahnma.fedorapeople.org/reviews/python-libgmail-0.1.8-2.fc8.src.rpm

Comment 4 Parag AN(पराग) 2007-12-14 03:05:56 UTC
(In reply to comment #2)
> License should be GPLv2, not GPLv2+.
> 
> $ grep License libgmail.py
> # License: GPL 2.0

oops. you are right. missed that libgmail.py clearly said its GPLv2.

(In reply to comment #3)
> I thought I read through the license file, COPYING and got that, but I could be
> wrong.  Change Made.
> 
> Latest Copies at
> 
> Spec URL: http://stahnma.fedorapeople.org/reviews/python-libgmail.spec
> SRPM URL:
> http://stahnma.fedorapeople.org/reviews/python-libgmail-0.1.8-2.fc8.src.rpm

Thanks. License looks correct now.
APPROVED.


Comment 5 Michael Stahnke 2008-01-20 08:24:19 UTC
New Package CVS Request
=======================
Package Name: python-libgmail
Short Description:  Library to provide access to Gmail via Python.
Owners: mastahnke@gmail.com
Branches: EL-4, EL-5, F7 , F8 
InitialCC: 
Cvsextras Commits: yes

Comment 6 Kevin Fenzi 2008-01-20 18:20:45 UTC
Please use Fedora Account name for the Owners field. 

cvs done.

Comment 7 Parag AN(पराग) 2008-01-26 05:13:55 UTC
Michael,
  Can you build this package so that I can review fuse-gmailfs?

Comment 8 Fedora Update System 2008-01-28 05:08:28 UTC
python-libgmail-0.1.8-2.fc7 has been submitted as an update for Fedora 7

Comment 9 Fedora Update System 2008-01-28 05:10:08 UTC
python-libgmail-0.1.8-2.fc8 has been submitted as an update for Fedora 8

Comment 10 Fedora Update System 2008-01-29 05:14:28 UTC
python-libgmail-0.1.8-2.fc8 has been pushed to the Fedora 8 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update python-libgmail'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F8/FEDORA-2008-1133

Comment 11 Parag AN(पराग) 2008-02-07 01:48:55 UTC
Closing this as this package has been successfully built for all requested
branches on build server.

Comment 12 Fedora Update System 2008-02-13 05:11:36 UTC
python-libgmail-0.1.8-2.fc7 has been pushed to the Fedora 7 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2008-02-13 05:16:25 UTC
python-libgmail-0.1.8-2.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.