Red Hat Bugzilla – Bug 422851
Review Request: fuse-gmailfs- Gmail Filesystem
Last modified: 2008-02-06 21:04:02 EST
Spec URL: http://stahnma.fedorapeople.org/reviews/fuse-gmailfs.spec SRPM URL: http://stahnma.fedorapeople.org/reviews/fuse-gmailfs-0.8.0-1.fc8.src.rpm Description: Gmail Filesystem provides a mountable Linux filesystem which uses your Gmail account as its storage medium. Gmail Filesystem is a Python application and uses the FUSE userland filesystem infrastructure to help provide the filesystem, and libgmail to communicate with Gmail.
Though packaging looks ok to me here. I will wait for other dependencies to be build in rawhide then will review this.
Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. 828417eb7355b61b0f474eabc826317f gmailfs-0.8.0.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present which are small. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI App. SHOULD: I am not sure about these messages in build.log /usr/lib/rpm/pythondeps.sh: line 8: python: command not found But, I think good to add BR:python Koji build at http://koji.fedoraproject.org/koji/taskinfo?taskID=380349 APPROVED.
New Package CVS Request ======================= Package Name: fuse-gmailfs Short Description: Gmail Filesystem Owners: stahnma Branches: EL-4, EL-5, F7 , F8 InitialCC: Cvsextras Commits: yes
CVS Done
Closing this as this package has been successfully built for all requested branches on build server.