Spec URL: http://dev.laptop.org/~rwh/sugar-evince.spec SRPM URL: http://dev.laptop.org/~rwh/sugar-evince-2.20.0-1.src.rpm Description: evince is a GNOME-based document viewer. This is the version developed for OLPC. It is built as a library to support embedding.
It doesn't build on x86_64. I uploaded a new spec here with that fixed. http://dev.laptop.org/~marco/sugar-evince.spec rpmlint output: [marco@localhost SPECS]$ rpmlint /home/marco/rpmbuild/RPMS/x86_64/sugar-evince-2.20.0-1.x86_64.rpm sugar-evince.x86_64: W: no-documentation sugar-evince.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libevince.so sugar-evince.x86_64: E: library-without-ldconfig-postin /usr/lib64/libevince.so.0.0.0 sugar-evince.x86_64: E: library-without-ldconfig-postun /usr/lib64/libevince.so.0.0.0 sugar-evince.x86_64: E: description-line-too-long evince is a GNOME-based document viewer. This is the version developed for OLPC. sugar-evince.x86_64: W: invalid-license GPL [marco@localhost SPECS]$ rpmlint /home/marco/rpmbuild/SRPMS/sugar-evince-2.20.0-1.src.rpm sugar-evince.src: W: mixed-use-of-spaces-and-tabs (spaces: line 33, tab: line 5) sugar-evince.src: E: description-line-too-long evince is a GNOME-based document viewer. This is the version developed for OLPC. sugar-evince.src: W: invalid-license GPL [marco@localhost SPECS]$ scp sugar-evince.spec dev.laptop.org:~/marco/public_html [marco@localhost SPECS]$ scp sugar-evince.spec dev.laptop.org:~/public_html sugar-evince.spec 100% 2251 2.2KB/s 00:00 [marco@localhost SPECS]$ rpmlint /home/marco/rpmbuild/SRPMS/sugar- sugar-0.70.4-1.src.rpm sugar-datastore-0.2.3-1.src.rpm sugar-evince-2.20.0-1.src.rpm [marco@localhost SPECS]$ rpmlint /home/marco/rpmbuild/RPMS/x86_64/sugar-evince-python-2.20.0-1.x86_64.rpm sugar-evince-python.x86_64: W: no-documentation sugar-evince-python.x86_64: W: invalid-license GPL [marco@localhost SPECS]$ rpmlint /home/marco/rpmbuild/RPMS/x86_64/sugar-evince-debuginfo-2.20.0-1.x86_64.rpm sugar-evince-debuginfo.x86_64: W: invalid-license GPL
Updated spec file at link, remaining rpmlint output: [marco@localhost SPECS]$ rpmlint /home/marco/rpmbuild/RPMS/x86_64/sugar-evince-2.20.0-1.x86_64.rpm sugar-evince.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libevince.so sugar-evince.x86_64: W: invalid-license GFDL+ sugar-evince.x86_64: W: one-line-command-in-%post /sbin/ldconfig sugar-evince.x86_64: W: one-line-command-in-%postun /sbin/ldconfig [marco@localhost SPECS]$ rpmlint /home/marco/rpmbuild/SRPMS/sugar-evince-2.20.0-1.src.rpm sugar-evince.src: W: invalid-license GFDL+ [marco@localhost SPECS]$ rpmlint /home/marco/rpmbuild/RPMS/x86_64/sugar-evince-python-2.20.0-1.x86_64.rpm sugar-evince-python.x86_64: W: no-documentation sugar-evince-python.x86_64: W: invalid-license GFDL+
taking a quick look mostly ok. You need to bump release during review and include in the changelog what you fix the URL should point to a page that has information on the wiki. and Source must be a url pointing to where source can be accessed for verification. at Marco's request ill take the review over
Updated spec and SRPM according to comments. To be found at: Spec URL: http://dev.laptop.org/~rwh/sugar-evince.spec SRPM URL: http://dev.laptop.org/~rwh/sugar-evince-2.20.0-2.src.rpm
looks good now. sha1sum matches upstream e8c8f1a1f181bd7de52baee257270adfa114c5fc evince-2.20.0.tar.bz2 e8c8f1a1f181bd7de52baee257270adfa114c5fc fedora/SOURCES/evince-2.20.0.tar.bz2 Approved
New Package CVS Request ======================= Package Name: sugar-evince Short Description: OLPC version of the evince document viewer Owners: reinier, mpg Branches: OLPC-2 InitialCC: reinier, mpg Cvsextras Commits: no
cvs done
Closing bug
Package Change Request ====================== Package Name: sugar-evince New Branches: OLPC-4 Owners: dsd mpg erikos tomeu
cvs done.