Spec URL: http://pingoured.dyndns.org/public/RPM/fprint_demo/fprint_demo.spec SRPM URL: http://pingoured.dyndns.org/public/RPM/fprint_demo/fprint_demo-0.4-2.fc8.src.rpm Description: Graphical tool to demonstrate how works for the fprint drivers
Packaging looks ok. except I think you should install icon file /usr/share/pixmaps Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream. 32e663a938e19801bdd17105d5c4d310 fprint_demo-0.4.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present in separate -doc subpackage. + BuildRequires are proper. + Compiler flags are honored correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + Desktop files handled correctly. + no scriptlets are used. + GUI app. APPROVED. SHOULD: Change install location of fprint-icon.png to /usr/share/pixmaps
ping?
pong, sorry about that I have been busy the past days New Package CVS Request ======================= Package Name: fprint_demo Short Description: Demo of the fprint drivers Owners: pingou Branches: F-7 F-8 Cvsextras Commits: yes
cvs done.
is this built?
I had to push the dependancies to stable before. It is now waiting for testing
fprint_demo-0.4-3.fc8 has been pushed to the Fedora 8 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update fprint_demo'
fprint_demo-0.4-3.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update fprint_demo'
fprint_demo-0.4-3.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
fprint_demo-0.4-3.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.