Bug 427699 - Review Request: fprint_demo - Demo of the fprint drivers
Review Request: fprint_demo - Demo of the fprint drivers
Status: CLOSED CURRENTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-06 16:27 EST by Pierre-Yves
Modified: 2008-01-29 00:17 EST (History)
2 users (show)

See Also:
Fixed In Version: 0.4-3.fc8
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-01-29 00:13:11 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Pierre-Yves 2008-01-06 16:27:26 EST
Spec URL: http://pingoured.dyndns.org/public/RPM/fprint_demo/fprint_demo.spec
SRPM URL: http://pingoured.dyndns.org/public/RPM/fprint_demo/fprint_demo-0.4-2.fc8.src.rpm
Description: 
Graphical tool to demonstrate how works for the fprint drivers
Comment 1 Parag AN(पराग) 2008-01-07 00:50:26 EST
Packaging looks ok.
except I think you should install icon file /usr/share/pixmaps


Review:
+ package builds in mock (rawhide i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
32e663a938e19801bdd17105d5c4d310  fprint_demo-0.4.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present in separate -doc subpackage.
+ BuildRequires are proper.
+ Compiler flags are honored correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Desktop files handled correctly.
+ no scriptlets are used.
+ GUI app.

APPROVED.

SHOULD:
  Change install location of fprint-icon.png to /usr/share/pixmaps

Comment 2 Parag AN(पराग) 2008-01-12 10:14:06 EST
ping?
Comment 3 Pierre-Yves 2008-01-12 11:46:36 EST
pong,
sorry about that I have been busy the past days

New Package CVS Request
=======================
Package Name: fprint_demo 
Short Description: Demo of the fprint drivers
Owners: pingou
Branches: F-7 F-8
Cvsextras Commits: yes
Comment 4 Kevin Fenzi 2008-01-12 15:39:30 EST
cvs done.
Comment 5 Parag AN(पराग) 2008-01-18 09:17:31 EST
is this built?
Comment 6 Pierre-Yves 2008-01-18 10:45:15 EST
I had to push the dependancies to stable before.

It is now waiting for testing
Comment 7 Fedora Update System 2008-01-22 10:50:34 EST
fprint_demo-0.4-3.fc8 has been pushed to the Fedora 8 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update fprint_demo'
Comment 8 Fedora Update System 2008-01-22 10:55:18 EST
fprint_demo-0.4-3.fc7 has been pushed to the Fedora 7 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update fprint_demo'
Comment 9 Fedora Update System 2008-01-29 00:13:09 EST
fprint_demo-0.4-3.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 10 Fedora Update System 2008-01-29 00:17:27 EST
fprint_demo-0.4-3.fc7 has been pushed to the Fedora 7 stable repository.  If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.