Bug 428008
| Summary: | RFE: Show the certification plan to people on the CC list | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Retired] Red Hat Hardware Certification Program | Reporter: | David Aquilina <dwa> | ||||||||
| Component: | Hardware Catalog | Assignee: | XINSUN <xisun> | ||||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Yu Shao <yshao> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | 5 | CC: | bryan.christ, bxu, efeng, flanagan, jaime.ricardo.perez, lee.ha, rlandry, xiqin, ykun, yshao | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | 3.2rh-20080801.1 | Doc Type: | Bug Fix | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2008-08-04 17:56:05 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 457596 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
David Aquilina
2008-01-08 17:15:34 UTC
Created attachment 311685 [details]
Patch Fix:
1.Use "bug.cc.size > 0 && lsearch(bug.cc,user.login) != -1" as the judge
condition for people in the "CC" list.
2.In the @@ -93,6 +93,10 @@ of the edit.html.tmpl: show the testplan to the
people who is in the "CC" list while not in the "canedit" role.
(canedit role includes:
the reporter,
assigned_to,
qa_contact,
useringroup('hwcert_edit')
)
So if one person who isn't in the "canedit" role but in the "CC" list, afer
deploying this patch, he/she can see the below cert's info:
summary,
testplan,
comments,
external_bugzilla_link,
[clone] (IF user also canclone)
Rob,
please have a look @ this patch & review.
Thank you very much.
Best Regards!
Nicho
Ps:
Those people who are in the "CC" list can see the testplan view but can not
do any changes against testplan after above patch's deploying.
Nicho
Created attachment 312390 [details]
Patch Improve:
Use below code:
[% oncc = 0 %]
[% FOREACH cc = bug.cc %]
[% IF user.login == cc %]
[% oncc = 1 %]
[% END %]
[% END %]
instead of
[% oncc = (bug.cc.size > 0 && lsearch(bug.cc,user.login) != -1) ? 1 : 0 %]
Does this last patch disable the cc users from setting the dropdown from patch in 191704? test passed on hwcert-web2 |