Spec URL: http://jbowes.fedorapeople.org/tmp/system-summary.spec SRPM URL: http://jbowes.fedorapeople.org/tmp/system-summary-0.0.2-2.fc8.src.rpm Description: A simple "About this computer" screen that summarizes your system's hardware and software.
1)If direct download link of tarball is not available then add some text in comments on how tarball can be created? 2)for desktop file installation you should use desktop-file-install command. see http://fedoraproject.org/wiki/Packaging/Guidelines#head-d559ee7363418a5840ce63090c608c991cd39ce6 here, you may like to add --vendor="fedora" 3) rpmlint output on srpm gave me system-summary.src: W: strange-permission system-summary.spec 0600 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions.
Hi: Updated spec and srpm: Spec URL: http://jbowes.fedorapeople.org/tmp/system-summary.spec SRPM URL: http://jbowes.fedorapeople.org/tmp/system-summary-0.0.3-1.fc8.src.rpm (In reply to comment #1) > 1)If direct download link of tarball is not available then add some text in > comments on how tarball can be created? > > 2)for desktop file installation you should use desktop-file-install command. > see > http://fedoraproject.org/wiki/Packaging/Guidelines#head-d559ee7363418a5840ce63090c608c991cd39ce6 > here, you may like to add --vendor="fedora" > > 3) rpmlint output on srpm gave me > system-summary.src: W: strange-permission system-summary.spec 0600 > A file that you listed to include in your package has strange > permissions. Usually, a file should have 0644 permissions. I've fixed 1. (created a download location for the tarball) and 2., 3. is an artifact of how I made the srpm (rpmbuild -ts), and will go away once everything is in distcvs. Thanks for taking a look!
1) You are missing BuildRequires: python-devel 2) use --vendor="Fedora" like --vendor="fedora" 3) you added fedora tag to desktop file that mean your file name will be changed from system-summary.desktop to fedora-system-summary.desktop so correct it under %files section
Ok, all three are fixed up. And I actually tested the changes this time ;)
and where can I find new SRPM link? I mean where should I look for review of this package :)
(In reply to comment #5) > and where can I find new SRPM link? I mean where should I look for review of > this package :) haha, oops. Spec URL: http://jbowes.fedorapeople.org/tmp/system-summary.spec SRPM URL: http://jbowes.fedorapeople.org/tmp/system-summary-0.0.3-2.fc8.src.rpm
When I rpmbuild above SPEC on F8 and installed it and tried to start it from console, I got fatal: unable to import system_summary No module named system_summary.main What should be problem?
(In reply to comment #7) > When I rpmbuild above SPEC on F8 and installed it and tried to start it from > console, I got > fatal: unable to import system_summary > No module named system_summary.main > > What should be problem? Kind of odd. Is that just running 'system-summary'? I've had no problems on my F8 machine
sorry its working fine. I had a tarball installation in /usr/local and rpm installation in /usr. rpmlint is silent. verified upstream source 29adfb43cb8c00771d7d69271b8c7594 system-summary-0.0.3.tar.bz2 Desktop files handled correctly. APPROVED.
Great! Thanks for the review!
New Package CVS Request ======================= Package Name: system-summary Short Description: A quick summary of system hardware Owners: jbowes Branches: F-8 InitialCC: Cvsextras Commits: yes
cvs done.
Is this built for F-8 branch?
It is now. Thanks for the reminder!