Hide Forgot
Spec URL: http://svahl.fedorapeople.org/dragonplayer/dragonplayer.spec SRPM URL: http://svahl.fedorapeople.org/dragonplayer/dragonplayer-2.0-0.1.beta1.fc8.src.rpm Description: A simple video player for KDE 4. Features: * Simple interface that does not get in the way * Resumes where you left off when replaying a video * Support for subtitles Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=345354
Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. 8fffeb9fa14e2d86a4ad539b392496d3 dragonplayer-2.0_beta1.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text COPYING is included in package. + %doc is small so no need of -doc subpackage. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no .pc files are present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + Desktop file installed correctly. + scriptlets are used. + GUI app. SHOULD: remove mkdir %{buildroot} from %install. APPROVED.
> SHOULD: > remove mkdir %{buildroot} from %install. Just to understand this: This should be removed because the directory is also created by "make install DESTDIR=%{buildroot}"? > APPROVED. Thx. New Package CVS Request ======================= Package Name: dragonplayer Short Description: A simple video player for KDE 4 Owners: svahl,rdieter,kkofler,ltinkl,than Branches: InitialCC: Cvsextras Commits: no
cvs done. Any particular reason for the cvsextras commits: no?
(In reply to comment #3) > cvs done. Thx > Any particular reason for the cvsextras commits: no? Out of habit. I don't want every new maintainer to be able to make changes to this package (see the discussion on fedora-devel-list some time ago). In my opinion the kde-sig should be sufficent.