Bug 431237 - Review Request: perl-Text-Format - Various subroutines to format text
Review Request: perl-Text-Format - Various subroutines to format text
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jason Tibbitts
Fedora Extras Quality Assurance
:
Depends On:
Blocks: 428113
  Show dependency treegraph
 
Reported: 2008-02-01 12:30 EST by Xavier Bachelot
Modified: 2008-02-02 05:43 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-02-02 05:43:16 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tibbs: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Xavier Bachelot 2008-02-01 12:30:14 EST
Spec URL: http://washington.kelkoo.net/fedora/SPECS/perl-Text-Format.spec
SRPM URL: http://washington.kelkoo.net/fedora/SRPMS/perl-Text-Format-0.52-1.fc8.src.rpm
Description: 
The format routine will format under all circumstances even if the width isn't
enough to contain the longest words. Text::Wrap will die under these
circumstances, although I am told this is fixed. If columns is set to a small
number and words are longer than that and the leading 'whitespace' than there
will be a single word on each line. This will let you make a simple word list
which could be indented or right aligned. There is a chance for croaking if you
try to subvert the module. If you don't pass in text then the internal text is
worked on, though not modified. Text::Format is meant for more powerful text
formatting than Text::Wrap allows. I also have a module called Text::NWrap that
is meant as a direct replacement for Text::Wrap. Text::NWrap requires
Text::Format since it uses Text::Format->format to do the actual wrapping but
gives you the interface of Text::Wrap.
Comment 1 Jason Tibbitts 2008-02-01 14:09:03 EST
Hmm, another decade-old Perl module.  There seems to be a rash of them lately.

* source files match upstream:
   3790c5bc7b5f66d1264fd013050c2097b5867bc737dc6c676d0794a3984aa9a1  
   Text-Format0.52.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(Text::Format) = 0.52
   perl-Text-Format = 0.52-1.fc9
  =
   perl >= 0:5.003
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(strict)
   perl(vars)

* %check is present and all tests pass:
   All tests successful.
   Files=2, Tests=13,  1 wallclock secs ( 0.02 cusr +  0.00 csys =  0.02 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED
Comment 2 Jason Tibbitts 2008-02-01 14:33:34 EST
Actually, now that I read a bit more clisely, I would also recommend removing
the last two sentences of %description, as they're not really descriptive of
this module:

I also have a module called Text::NWrap that is meant as a direct replacement
for Text::Wrap. Text::NWrap requires Text::Format since it uses
Text::Format->format to do the actual wrapping but gives you the interface of
Text::Wrap.
Comment 3 Xavier Bachelot 2008-02-01 14:58:47 EST
Thanks for the review, Jason. I will fix the description after importing the
package.

New Package CVS Request
=======================
Package Name: perl-Text-Format
Short Description: Various subroutines to format text
Owners: xavierb
Branches: F-8 EL-4 EL-5
InitialCC: 
Cvsextras Commits: yes
Comment 4 Kevin Fenzi 2008-02-01 16:59:42 EST
cvs done.
Comment 5 Xavier Bachelot 2008-02-02 05:43:16 EST
Imported and built for devel, F-8, EL-4 and EL-5.

Note You need to log in before you can comment on or make changes to this bug.