Spec URL: http://mtasaka.fedorapeople.org/Review_request/libdstr/libdstr.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/libdstr/libdstr-20080124-1.fc8.src.rpm Description: libdstr is a library containing Dstr, Dave's String class. Koji rebuild results: For dist-f9: http://koji.fedoraproject.org/koji/taskinfo?taskID=399004 For dist-f8-updates-candidate: http://koji.fedoraproject.org/koji/taskinfo?taskID=398997
Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 3a35a29f33b22c04fe3d2ebe5dc29b5f libdstr-20080124.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + Compiler flags used correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no .pc file present. + -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + ldconfig scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package libdstr-20080124-1.fc9 -> Provides: libdstr.so.2Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libdstr.so.2 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libm.so.6 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) rtld(GNU_HASH) + Package libdstr-devel-20080124-1.fc9 -> Requires: libdstr.so.2 Not sure why Requires for libdstr-devel-20080124-1.fc9 is missing libdstr = 20080124-1.fc9 But when I did "rpmbuild -ba libdstr.spec" on my machine I see its showing that requires on main package. Am I missing something to look? Note:- I used build.log from your F9 scratch build for this review. But for F8 build I can see that Requires is present.
Well, actually something strange. On my *rawhide* machine, when I manually try "rpmbuild -ba", the compilation log says: ---------------------------------------------------------------------------- Processing files: libdstr-devel-20080124-1.fc9 Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 Requires: libdstr.so.2 Processing files: libdstr-debuginfo-20080124-1.fc9 ---------------------------------------------------------------------------- But ---------------------------------------------------------------------------- [tasaka1@localhost SPECS]$ rpm -qp --requires ../RPMS/i386/libdstr-devel-20080124-1.fc9.i386.rpm libdstr = 20080124-1.fc9 libdstr.so.2 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 ---------------------------------------------------------------------------- So actually libdstr-devel requires libdstr = %name-%version. Perhaps "rpm" side (and packages "rpm" depends on) changed somewhat? Anyway it seems to be working. (Maybe I have to file a bug against "rpm"??)
(In reply to comment #2) > Well, actually something strange. On my *rawhide* machine, > when I manually try "rpmbuild -ba", the compilation log says: > ---------------------------------------------------------------------------- > Processing files: libdstr-devel-20080124-1.fc9 > Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 > rpmlib(PayloadFilesHavePrefix) <= 4.0-1 > Requires: libdstr.so.2 > Processing files: libdstr-debuginfo-20080124-1.fc9 > ---------------------------------------------------------------------------- > But > ---------------------------------------------------------------------------- > [tasaka1@localhost SPECS]$ rpm -qp --requires > ../RPMS/i386/libdstr-devel-20080124-1.fc9.i386.rpm > libdstr = 20080124-1.fc9 > libdstr.so.2 > rpmlib(CompressedFileNames) <= 3.0.4-1 > rpmlib(PayloadFilesHavePrefix) <= 4.0-1 > ---------------------------------------------------------------------------- > So actually libdstr-devel requires libdstr = %name-%version. > Perhaps "rpm" side (and packages "rpm" depends on) changed somewhat? > Anyway it seems to be working. (Maybe I have to file a bug against > "rpm"??) looks like that. APPROVED.
Thanks!! New Package CVS Request ======================= Package Name: libdstr Short Description: Dave's String class Owners: mtasaka Branches: F-8 F-7 InitialCC: Cvsextras Commits: yes
(In reply to comment #3) > (In reply to comment #2) > > Well, actually something strange. On my *rawhide* machine, > > when I manually try "rpmbuild -ba", the compilation log says: > > ---------------------------------------------------------------------------- > > Processing files: libdstr-devel-20080124-1.fc9 > > Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 > > rpmlib(PayloadFilesHavePrefix) <= 4.0-1 > > Requires: libdstr.so.2 > > Processing files: libdstr-debuginfo-20080124-1.fc9 > > ---------------------------------------------------------------------------- > > But > > ---------------------------------------------------------------------------- > > [tasaka1@localhost SPECS]$ rpm -qp --requires > > ../RPMS/i386/libdstr-devel-20080124-1.fc9.i386.rpm > > libdstr = 20080124-1.fc9 > > libdstr.so.2 > > rpmlib(CompressedFileNames) <= 3.0.4-1 > > rpmlib(PayloadFilesHavePrefix) <= 4.0-1 > > ---------------------------------------------------------------------------- > > So actually libdstr-devel requires libdstr = %name-%version. > > Perhaps "rpm" side (and packages "rpm" depends on) changed somewhat? > > Anyway it seems to be working. (Maybe I have to file a bug against > > "rpm"??) > > looks like that. Filed as bug 431721 as not only libdstr seems affected. http://koji.fedoraproject.org/koji/taskinfo?taskID=398488 http://koji.fedoraproject.org/koji/taskinfo?taskID=398489
cvs done.
Rebuilt on all archs, thank you for your review!