Bug 431976 - Review Request: yoltia - Qt based picture editing program
Summary: Review Request: yoltia - Qt based picture editing program
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-02-08 07:06 UTC by Krzysztof Kurzawski
Modified: 2008-02-09 09:57 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-02-09 09:57:38 UTC
Type: ---
Embargoed:
panemade: fedora-review+
dennis: fedora-cvs+


Attachments (Terms of Use)
suggested patch to compile yoltia with gcc43 (878 bytes, patch)
2008-02-08 09:46 UTC, Mamoru TASAKA
no flags Details | Diff

Description Krzysztof Kurzawski 2008-02-08 07:06:34 UTC
Spec URL: http://kurzawa.nonlogic.org/rpm/yoltia/yoltia.spec
SRPM URL: http://kurzawa.nonlogic.org/rpm/yoltia/yoltia-0.22.1-1.fc8.src.rpm
Description: Yoltia is a computer program for editing image files. It provides the 
functionality to do simple changes to a large number of pictures quickly and 
very comfortable and exactly. Most of its usage is done via hotkeys. Yoltia is
written for Linux systems and published as free software under GPL.

Comment 1 Parag AN(पराग) 2008-02-08 08:37:31 UTC
koji build failed for me
http://koji.fedoraproject.org/koji/taskinfo?taskID=402634

Comment 2 Krzysztof Kurzawski 2008-02-08 09:17:13 UTC
But when I tried build this package in koji it was ok.
http://koji.fedoraproject.org/koji/taskinfo?taskID=402731

What should I do?

Comment 3 manuel wolfshant 2008-02-08 09:28:12 UTC
Krzysztof: you've tested only on F8, but the preferred testing target is rawhide.

Comment 4 Mamoru TASAKA 2008-02-08 09:46:38 UTC
Created attachment 294329 [details]
suggested patch to compile yoltia with gcc43

Please try this patch.

Comment 5 Parag AN(पराग) 2008-02-08 10:00:42 UTC
Hey mtasaka,
   Thanks for this patch. I just used that and this package built successfully
on my rawhide machine now. I was actually figuring out how to solve problem in
qt packages but looked like it is gcc issue from patch name.

Comment 6 Krzysztof Kurzawski 2008-02-08 10:06:32 UTC
Fixed
Spec URL: http://kurzawa.nonlogic.org/rpm/yoltia/yoltia.spec
SRPM URL: http://kurzawa.nonlogic.org/rpm/yoltia/yoltia-0.22.1-2.fc8.src.rpm

Thanks for review and thanks for patch!

Comment 7 Parag AN(पराग) 2008-02-08 10:43:50 UTC
Review:
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=402818
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
ae49da3e9f22569d81b278a1e0eb7b42  yoltia-0.22.1.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags are honored correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Desktop file installed correctly.
+ GUI app.

APPROVED.

Comment 8 Krzysztof Kurzawski 2008-02-08 10:47:10 UTC
New Package CVS Request
=======================
Package Name: yoltia
Short Description: Qt based picture editing program
Owners: kurzawa
Branches: F-7 F-8
InitialCC:
Cvsextras Commits: yes

Comment 9 Dennis Gilmore 2008-02-08 18:32:44 UTC
CVS Done

Comment 10 Krzysztof Kurzawski 2008-02-09 09:57:38 UTC
Imported and built. Thanks again fo review!


Note You need to log in before you can comment on or make changes to this bug.