Bug 431976 - Review Request: yoltia - Qt based picture editing program
Review Request: yoltia - Qt based picture editing program
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-02-08 02:06 EST by Krzysztof Kurzawski
Modified: 2008-02-09 04:57 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-02-09 04:57:38 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
panemade: fedora‑review+
dennis: fedora‑cvs+


Attachments (Terms of Use)
suggested patch to compile yoltia with gcc43 (878 bytes, patch)
2008-02-08 04:46 EST, Mamoru TASAKA
no flags Details | Diff

  None (edit)
Description Krzysztof Kurzawski 2008-02-08 02:06:34 EST
Spec URL: http://kurzawa.nonlogic.org/rpm/yoltia/yoltia.spec
SRPM URL: http://kurzawa.nonlogic.org/rpm/yoltia/yoltia-0.22.1-1.fc8.src.rpm
Description: Yoltia is a computer program for editing image files. It provides the 
functionality to do simple changes to a large number of pictures quickly and 
very comfortable and exactly. Most of its usage is done via hotkeys. Yoltia is
written for Linux systems and published as free software under GPL.
Comment 1 Parag AN(पराग) 2008-02-08 03:37:31 EST
koji build failed for me
http://koji.fedoraproject.org/koji/taskinfo?taskID=402634
Comment 2 Krzysztof Kurzawski 2008-02-08 04:17:13 EST
But when I tried build this package in koji it was ok.
http://koji.fedoraproject.org/koji/taskinfo?taskID=402731

What should I do?
Comment 3 manuel wolfshant 2008-02-08 04:28:12 EST
Krzysztof: you've tested only on F8, but the preferred testing target is rawhide.
Comment 4 Mamoru TASAKA 2008-02-08 04:46:38 EST
Created attachment 294329 [details]
suggested patch to compile yoltia with gcc43

Please try this patch.
Comment 5 Parag AN(पराग) 2008-02-08 05:00:42 EST
Hey mtasaka,
   Thanks for this patch. I just used that and this package built successfully
on my rawhide machine now. I was actually figuring out how to solve problem in
qt packages but looked like it is gcc issue from patch name.
Comment 6 Krzysztof Kurzawski 2008-02-08 05:06:32 EST
Fixed
Spec URL: http://kurzawa.nonlogic.org/rpm/yoltia/yoltia.spec
SRPM URL: http://kurzawa.nonlogic.org/rpm/yoltia/yoltia-0.22.1-2.fc8.src.rpm

Thanks for review and thanks for patch!
Comment 7 Parag AN(पराग) 2008-02-08 05:43:50 EST
Review:
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=402818
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
ae49da3e9f22569d81b278a1e0eb7b42  yoltia-0.22.1.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags are honored correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Desktop file installed correctly.
+ GUI app.

APPROVED.
Comment 8 Krzysztof Kurzawski 2008-02-08 05:47:10 EST
New Package CVS Request
=======================
Package Name: yoltia
Short Description: Qt based picture editing program
Owners: kurzawa
Branches: F-7 F-8
InitialCC:
Cvsextras Commits: yes
Comment 9 Dennis Gilmore 2008-02-08 13:32:44 EST
CVS Done
Comment 10 Krzysztof Kurzawski 2008-02-09 04:57:38 EST
Imported and built. Thanks again fo review!

Note You need to log in before you can comment on or make changes to this bug.