Created attachment 294387 [details]
initial patch

Here's a patch to implement ext4dev, xfs, and fix a "raiserfs" typo.

Note: ext4dev will at some point change to "ext4" so some changes will need to
be made at that point.

A test for the fully ext4-capable version of e2fsprogs would probably also be
good.

I felt a little bad with all the cut and paste; perhaps ext2/3/4 could use some
class inheritance?

If you'd like a simpler test for get_label, you could just call e2label rather
than parsing out tune2fs output.

Thanks,

-Eric

This is very nice! Thanks kindly. I am in the middle of gitifying the s-c-lvm
repo, but will have all settled by early next week and will get this built.

Adding FutureFeature keyword to RFE's.

Can the patch in comment #1 be applied before F-10 release. And given the latest update to the ext4 support, I believe all the reference to ext4dev can now be changed to ext4.

Created attachment 319868 [details]
Updated patch

Here's an updated patch.  This has been open for almost a year, is there a reason these changes can't be included?

Thanks,
-Eric

Fedora 11 will default to ext4, it will great if this patch can be applied now. Thanks.

PS: If its OK with the package owner, I can go ahead and apply the patch, and build it in koji myself.

This patch is being included now. s-c-lvm is getting some much needed love. :) There are also a few /etc/fstab issues that are getting ironed out as well.

I wonder if there is anything else I can do (besides providing a patch over 1 year ago, and a subsequent updated patch...) to make this bug move.  ext4 is the default fs for F11, and s-c-lvm still doesn't recognize it.

Perhaps I could commit it to rawhide for you?

Thanks,
-Eric

another vote for making this work in F11. Seems kind of bad that it doesn't.

Jim, ping?

I have Preview Release F11 installed and still does not work. I have been allowing updates. Checked yum update system-config-lvm and none are available.

No, it won't work, the maintainer has not merged the provided patches.

Jim, perhaps you can just close this WONTFIX with an explanation of why, so people aren't left scratching their heads?  Because by now, I am too.

Seems like a good candidate for an update

Hi folks, Jim has promised a build by next week. Too late for the F11 drop, but an update is sufficient for fixing this.

Any status on this update?

Not sure if that was an update. But today I try running s-c-lvm and I get this.
[root@wolf ~]# system-config-lvm
Traceback (most recent call last):
  File "/usr/sbin/system-config-lvm", line 173, in <module>
    runFullGUI()
  File "/usr/sbin/system-config-lvm", line 158, in runFullGUI
    blvm = baselvm(glade_xml, app)
  File "/usr/sbin/system-config-lvm", line 108, in __init__
    self.volume_tab_view = Volume_Tab_View(glade_xml, self.lvmm, self.main_win)
  File "/usr/share/system-config-lvm/Volume_Tab_View.py", line 133, in __init__
    self.prepare_tree()
  File "/usr/share/system-config-lvm/Volume_Tab_View.py", line 214, in prepare_tree
    self.model_factory.reload()
  File "/usr/share/system-config-lvm/lvm_model.py", line 164, in reload
    self.__PVs = self.__query_partitions()
  File "/usr/share/system-config-lvm/lvm_model.py", line 198, in __query_partitions
    multipath_data = multipath_obj.get_multipath_data()
  File "/usr/share/system-config-lvm/Multipath.py", line 53, in get_multipath_data
    block_devices.append(['/dev/' + words[9], words[4].rstrip(','), words[5]])
IndexError: list index out of range

My current version is.system-config-lvm-1.1.4-5.1.fc11.noarch

Forgot to mention after I get this error then it dies.

I've requested commit access to s-c-l, maybe we can get it in that way if Jim approves.

-Eric

I've built w/ the patch and put a test rpm & srpm up at http://sandeen.fedorapeople.org/s-c-l/ if anyone wants to give it a whirl.

YES!!  Works for me, can now see and create ext4 LVs.  Thank you, thank you, thank you.

Thank You Very Much. It works great. I was able to make new volumes, mount existing volumes with ext4.

This patch works for me as well.

Performed yum update and received system-config-lvm-1.1.4-6.fc12.noarch. This overwrote system-config-lvm-1.1.4-5.1.fc12.ers.noarch. The newer one does not work. Had to remove and place your fix back on. The one did not recognize ext4.

We seem to have a new maintainer for the package.  Hopefully the patch will get in -this- year ;)

-Eric

Hi Marek, welcome to the bug :)  A couple people have tested the patch and it seems to work, but i'm sure it could be cleaned up by someone who can write python better than me.  :)

Thanks,
-Eric

Hi,

Patch looks ok for me. Give me some time to build upstream

http://git.fedorahosted.org/git/system-config-lvm.git

*** Bug 508889 has been marked as a duplicate of this bug. ***