Bug 432310 - Review Request: compat-guichan06 - compatibility package for older guichan release
Summary: Review Request: compat-guichan06 - compatibility package for older guichan re...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review   
(Show other bugs)
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Hans de Goede
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 426746
TreeView+ depends on / blocked
Reported: 2008-02-11 05:42 UTC by Wart
Modified: 2008-04-04 22:31 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2008-04-04 22:31:51 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
hdegoede: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Wart 2008-02-11 05:42:20 UTC
Spec URL: http://www.kobold.org/~wart/fedora/compat-guichan06.spec
SRPM URL: http://www.kobold.org/~wart/fedora/compat-guichan06-0.6.1-3.fc9.src.rpm
Compatibility library for guichan version 0.6.

The main guichan package will be upgraded to the latest 0.7.1 release at the same time that this package is imported.  Currently only one package depends on libguichan-0.6.1 (ballz), and should not require a rebuild.  It will, however, need to 'Requires: compat-guichan06-devel' and be patched slightly if/when it ever needs a rebuild.

Comment 1 Hans de Goede 2008-02-15 07:52:02 UTC
Some questions / remarks.

I see this still installs its headers directly under /usr/include (atleast
guichan.hpp), wouldn't it be better to instead put them under
/usr/include/guichan-0.6 (both guichan.hpp and the guichan header dir).

Since this is also providing a -devel it should not be called compat-guichan06
but just guichan06.

Also is ballz the only user of guichan-0.6 ? If it is I could take a stab at
porting it, that would be better then carrying multiple versions for just one

Comment 2 Wart 2008-02-15 20:16:17 UTC
Thanks for the quick check.  Here is the updtae that puts the headers in the
right place.


I don't understand the reasoning for dropping compat- from the package name. 
Why is 'compat-' not necessary for packages that provide a -devel subpackage?

As far as I know, ballz is the only dependency.  I agree that porting ballz
would be ideal, but I have not had any time to look at porting, and I know that
you've been pretty busy lately, so this compat package seemed the quickest way
to work around it.  It's probably still a good idea to keep this compat package,
however, in case there are any users who have compiled 3rd-party applications
against the library on their systems.

Comment 3 Hans de Goede 2008-02-17 15:24:56 UTC
I've tried building ballz with guichan-0.7.1, and it turns out that all that is
needed is a simple rebuild.

I though that you had already tried that?

Anyways that means that a compat package for guichan-0.6 isn't (really) needed
and if you do one for binary compatibility reasons, you should remove all the
files which normally go to -devel after make install, and then indeed cal;l it
compat-foo, without a -devel subpackage.

Comment 4 Hans de Goede 2008-02-29 20:47:23 UTC
Erm, ping? This no longer seems needed, so perhaps it should be closed, or ... ?

Comment 5 Wart 2008-03-02 18:54:25 UTC
I think it should stick around, but for F-8 only.  For F-9 we can upgrade to
guichan-0.7.1 and rebuild the affected packages.  I'd also still like to upgrade
guichan for F-8 to help fix a lingering manaworld bug, but think that at least
the .so bits from guichan 0.6 should remain in case any users have locally built
packages that need them.  The guichan 0.6.1 -devel bits can be dropped, however.

I'll update this package in the next day or so, and let you know in the same
timeframe when I'm about to push guichan-0.7.1 to rawhide.

Comment 6 Wart 2008-04-03 15:40:11 UTC
After a bit of a delay, here is the package with the -devel bits removed:


I'm also ready to build guichan-0.7.1 for Rawhide.

Comment 7 Hans de Goede 2008-04-03 16:14:57 UTC
Looks good, but since this now is a compat package (iow no devel, nothing in the
distro is building against, only made available for binary compatibility for old
apps if they need it), it should get the compat- back in its name.

Also I think we should only build this for F-8 and F-7, as we try not to keep
too much compat packages around in general.

Comment 8 Wart 2008-04-03 19:28:03 UTC


I agree that this should only exist for F8 and F7.  Nothing will require it in
F9, so there won't be any need to build it there.

Comment 9 Hans de Goede 2008-04-04 08:07:42 UTC

Comment 10 Wart 2008-04-04 15:49:22 UTC
New Package CVS Request
Package Name: compat-guichan06
Short Description: compatibility libraries for older guichan release
Owners: wart
Branches: F-8 F-7
Cvsextras Commits:

Comment 11 Kevin Fenzi 2008-04-04 15:58:05 UTC
cvs done.

Comment 12 Wart 2008-04-04 22:31:51 UTC
Imported and built for Rawhide.  I've also built this for F-7 and F-8, but will
wait to do the push until ballz, manaworld, and guichan are all ready.  guichan
is built for F-7 and F-8, but is waiting to be added to the build root so that
manaworld and ballz can be rebuilt.

Closing this, and will follow up with Hans via email to coordinate the other
package rebuilds.

Note You need to log in before you can comment on or make changes to this bug.