Spec URL: http://sandeen.fedorapeople.org/fio/fio.spec SRPM URL: http://sandeen.fedorapeople.org/fio/fio-1.18-1.fc8.src.rpm Description: fio is an I/O tool that will spawn a number of threads or processes doing a particular type of io action as specified by the user. fio takes a number of global parameters, each inherited by the thread unless otherwise parameters given to them overriding that setting is given. The typical use of fio is to write a job file matching the io load one wants to simulate. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=423559
1)Can you add some lines in comments on "Creation of tarball from git"? 2) License is GPLv2+ 3)Use install command as make install prefix=%{_prefix} mandir=%{_mandir} DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ==> this will take care of usage of macros and timestamp of man page. 4) explicit writing of attr for man page is not needed. make it simple as %{_mandir}/man1/*
The tarball was not in fact created from git, it is, as near as I can tell, a released tarball from the URL from the Source0: line. re: license, when I look at fio.c, it says: * The license below covers all files distributed with fio unless otherwise * noted in the file itself. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. Should both GPLv2 and GPLv2+ be listed? re: the other things; I'll fix those up, someday I'll be good at this :) new spec & src.rpm, except no license change (yet) is up... Thanks, -Eric
Oh I forgot to add; fio itself appears to be GPLv2, but it incorporates some files which are listed as GPLv2+
you should bump release and add changelog instead to create same SRPM again and again that may confuse reviewer. License is Ok GPLv2.
+ is OK - is Need work Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=425562 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 75de5c1adb944bfee44d126 fio-1.18.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honored correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. APPROVED.
Thanks for the quick review! New Package CVS Request ======================= Package Name: fio Short Description: Multithreaded IO generation tool Owners: sandeen Branches: F-8 InitialCC: Cvsextras Commits: yes
cvs done.
All set, thanks!
Package Change Request ====================== Package Name: fio New Branches: epel5, epel6 Owners: sandeen InitialCC:
I guess that should be: Package Change Request ====================== Package Name: fio New Branches: el5, el6 Owners: sandeen InitialCC:
Git done (by process-git-requests).
Package Change Request ====================== Package Name: fio New Branches: el7 Owners: sandeen InitialCC: