Hide Forgot
Spec URL: http://svahl.fedorapeople.org/ksig/ksig.spec SRPM URL: http://svahl.fedorapeople.org/ksig/ksig-1.1-0.1.20080213.fc8.src.rpm Description: KSig is a graphical tool for keeping track of many different email signatures. The signatures themselves can be edited through KSig's graphical user interface. A command-line interface is then available for generating random or daily signatures from a list. The command-line interface makes a suitable plugin for generating signatures in external mail clients such as KMail. Note for reviewers: ksig has no official release of the KDE4 port yet. So the svn version is packaged here. But it should be as usuable as the KDE 3 version (last change was over one month ago). To create the svn checkout a modified script from upstream was used. There is also existing a short documentation about how to create a new tarball at your own. rpmlint: ksig.i386: W: dangling-symlink /usr/share/doc/HTML/en/ksig/common /usr/share/doc/HTML/en/common ksig.i386: W: symlink-should-be-relative /usr/share/doc/HTML/en/ksig/common /usr/share/doc/HTML/en/common Normal warnings for KDE packages and could be ignored. scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=424847
I'm always missing something today. :( Spec URL: http://svahl.fedorapeople.org/ksig/ksig.spec SRPM URL: http://svahl.fedorapeople.org/ksig/ksig-1.1-0.2.20080213.fc8.src.rpm Changelog: - +R: xdg-utils - +BR: desktop-file-utils
I think Group should be Applications/Internet when I followed instructions to generate tarball packages in SRPM I got different tarball name but contents looked same b2ecb5bd331e0557bed03904f2fbbd17 ksig-1.1-svn.tar.bz2 485a276fa48bcc0980ec9e3862bf9d38 ksig-1.1.tar.bz2
Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=425557 + rpmlint is silent for SRPM. But NOT for RPM. ksig.i386: W: dangling-symlink /usr/share/doc/HTML/en/ksig/common /usr/share/doc/HTML/en/common ksig.i386: W: symlink-should-be-relative /usr/share/doc/HTML/en/ksig/common /usr/share/doc/HTML/en/common ==> Ok to accept + source files match upstream. b2ecb5bd331e0557bed03904f2fbbd17 ksig-1.1-svn.tar.bz2 485a276fa48bcc0980ec9e3862bf9d38 ksig-1.1.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honored correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + xdg-utils scriptlets are used. + Desktop file installed correctly. + GUI app. SHOULD: Group should be Applications/Internet APPROVED.
(In reply to comment #3)> SHOULD: > Group should be Applications/Internet I took Applications/Productivity from kdepim (ksig was used to be in kdepim). But Applications/Internet should also be fine. I'll change that after the import. (In reply to comment #3)> SHOULD: > APPROVED. Thx! New Package CVS Request ======================= Package Name: ksig Short Description: A graphical application to manage multiple email signatures Owners: svahl,than,rdieter,kkofler,ltinkl Branches: InitialCC: Cvsextras Commits: no
cvs done.
Thanks! Imported and build: http://koji.fedoraproject.org/koji/buildinfo?buildID=36504