Red Hat Bugzilla – Bug 432791
Review Request: epdfview - Lightweight PDF document viewer
Last modified: 2008-02-18 14:44:53 EST
Spec URL: http://michich.fedorapeople.org/epdfview/epdfview.spec
SRPM URL: http://michich.fedorapeople.org/epdfview/epdfview-0.1.6-1.fc9.src.rpm
ePDFView is a lightweight PDF document viewer using Poppler and GTK+ libraries.
The aim of ePDFView is to make a simple PDF document viewer, in the lines of
Evince but without using the Gnome libraries.
The package builds in mock and rpmlint sees no issues:
I did a scratch build in Koji too:
1)tarball packages in SRPM does not preserve upstream released tarball
timestamp. Good if you use wget and download tarball and package in SRPM.
2)To preserve timestamps from files being copied from upstream tarball use
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
3) Drop following from SPEC
as per said at
4)Use scriptlet of update-desktop-database as per given at
I can't see poppler-glib-devel on F8
(In reply to comment #2)
> 1)tarball packages in SRPM does not preserve upstream released tarball
> timestamp. Good if you use wget and download tarball and package in SRPM.
OK, I redownloaded with wget and the tarball now has the original timestamp.
> 2)To preserve timestamps from files being copied from upstream tarball use
> make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
Interesting, I've never seen this one mentioned in the guidelines. OK, done.
> 3) Drop following from SPEC
> Requires(post): desktop-file-utils
> Requires(postun): desktop-file-utils
> as per said at
I see. I was confused by obsolete instructions in
I have copied the snippet from ScriptletSnippets and fixed the wiki page
> 4)Use scriptlet of update-desktop-database as per given at
(In reply to comment #3)
> I can't see poppler-glib-devel on F8
True. poppler-glib-devel was split from poppler-devel in Rawhide.
I didn't originally plan to push the package to F8, but I have now made a
conditional special case in BuildRequires to make it build on F8 too.
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=434204
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags are honored correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ update-desktop-database scriptlets are used.
+ Desktop file installed correctly.
+ GUI app.
New Package CVS Request
Package Name: epdfview
Short Description: Lightweight PDF document viewer