Bug 433443 - Review Request: emacs-common-tuareg - Emacs mode for editing ocaml
Review Request: emacs-common-tuareg - Emacs mode for editing ocaml
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jason Tibbitts
Fedora Extras Quality Assurance
Depends On:
Blocks: 433430
  Show dependency treegraph
Reported: 2008-02-19 06:03 EST by Richard W.M. Jones
Modified: 2008-02-20 17:05 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2008-02-20 17:05:37 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tibbs: fedora‑review+
kevin: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Richard W.M. Jones 2008-02-19 06:03:15 EST
Spec URL: http://www.annexia.org/tmp/ocaml/emacs-common-tuareg.spec
SRPM URL: http://www.annexia.org/tmp/ocaml/emacs-common-tuareg-1.45.6-1.fc9.src.rpm
Description: Emacs mode for editing ocaml

Tuareg-mode is an add-on package for GNU Emacs for editing OCaml source
files.  It is much better than the default mode included in Emacs or
the one provided by INRIA.
Comment 1 Jason Tibbitts 2008-02-19 13:26:38 EST
Builds OK for me; I suggest you ping the xemacs maintainer to get some
assistance with the xemacs bits.

Why do you redefine %debug_package?  This is a noarch package and so doesn't
have a debug package in any case.

I really don't see the point in having a separate doc directory with the same
COPYING file in every subpackage; it really isn't necessary.  So far we're not
blocking on it, but I have to say I really don't understand why you would do that.

Currently all of the xemacs stuff is cruft since it's not being built, but I see
no problem in leaving it there in the hope that it can be made to work. 
However, if it's not ever going to be built then you get to drop the -common
package (and really the package should then be called just "emacs-tuareg").

You might want to consider dropping something into emacs-startdir so that this
package will work without additional configuration.  I think you can just put
append-tuareg.el there, although I don't know quite enough about emacs to say
that with certainty.

The only thing I see that needs changing is the debug_package thing, which is
really minor so I'll go ahead and approve this and you can remove it when you
check in.

* source files match upstream:
* package meets naming and versioning guidelines.
* package conforms to emacs packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   emacs-common-tuareg = 1.45.6-1.fc9

   emacs-tuareg = 1.45.6-1.fc9
   emacs(bin) >= 22.1.50
   emacs-common-tuareg = 1.45.6-1.fc9

   emacs-tuareg-el = 1.45.6-1.fc9
   emacs-tuareg = 1.45.6-1.fc9

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED, just remove the debug_package define when you check in.
Comment 2 Richard W.M. Jones 2008-02-19 14:20:20 EST
Thank you for quickly approving this.

debug_package: Force of habit .. I'll remove it.

xemacs: I've asked the upstream maintainer (of tuareg, not xemacs)
if he knows what is going on.  No reply yet.

I'll request CVS, remove debug_package, temporarily restructure
without xemacs as you suggest, and hopefully upstream will get back
to me about xemacs support.
Comment 3 Richard W.M. Jones 2008-02-19 14:22:32 EST
New Package CVS Request
Package Name: emacs-common-tuareg
Short Description: Emacs mode for editing ocaml
Owners: rjones
Branches: F-8
InitialCC: rjones
Cvsextras Commits: yes
Comment 4 Kevin Fenzi 2008-02-20 15:08:51 EST
cvs done.

Note You need to log in before you can comment on or make changes to this bug.