Spec URL: http://mmahut.fedorapeople.org/reviews/gnuradio/gnuradio.spec SRPM URL: http://mmahut.fedorapeople.org/reviews/gnuradio/gnuradio-3.1.1-1.fc8.src.rpm Description: GNU Radio is a collection of software that when combined with minimal hardware, allows the construction of radios where the actual waveforms transmitted and received are defined by software. What this means is that it turns the digital modulation schemes used in today's high performance wireless devices into software problems.
Does not build on ppc64 because sdcc package is not available for ppc64 arch yet (but it will be after Jesse's rebuild for gcc34).
Review for release 1.fc8: * RPM name is OK * Source gnuradio-3.1.1.tar.gz is the same as upstream * INSERT RESULT OF RUN TEST Needs work: * Spec file: some paths are not replaced with RPM macros (wiki: Packaging/Guidelines#macros) * Build failed in mock --- this I tried in fedora-8-x86_64, seemed like you were lacking python-devel-dependency checking for Python.h... no configure: error: cannot find usable Python headers error: Bad exit status from /var/tmp/rpm-tmp.17800 (%build) (18 checks have been run) Notes: %files usrp %defattr(-,root,root,-) Is usrp subpackage empty? I'll check once I manage to build it; mock builds are running right now
Created attachment 296101 [details] gnuradio-3.1.1-1.fc8 rpmlint Marek, Marek. 1.) Seems like you are missing the following: BuildRequires: boost-devel BuildRequires: python-devel BuildRequires: swig BuildRequires: doxygen 2.) This won't get packaged on 64bits, as your python modules are architecture dependent: Please replace python_sitelib definition with %{!?python_sitearch: %define python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(1)")} and its occurences with python_sitearch 3.) gnuradio-usrp sumpackage is really empty. Should it be? 4.) RPMLint doesn't like you, see the attachment. These definitely have to be addressed: gnuradio.x86_64: W: non-executable-in-bin ... gnuradio.x86_64: W: devel-file-in-non-devel-package ... 5.) You install libtool files which you should have %excluded: For example /usr/lib64/python2.5/site-packages/gnuradio/*.la
I hit a problem and trying to solve it with upstream. I'll let you know soon.
Spec URL: http://mmahut.fedorapeople.org/reviews/gnuradio/gnuradio.spec SRPM URL: http://mmahut.fedorapeople.org/reviews/gnuradio/gnuradio-3.1.1-1.fc8.src.rpm Koji build rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=490947 Koji build F8: http://koji.fedoraproject.org/koji/taskinfo?taskID=491008 - F8 does not build under ppc, because dependency sdcc is missing, will be solved by https://admin.fedoraproject.org/updates/F8/pending/sdcc-2.6.0-11.fc8 - gnuradio-3.1.1-gcc34.patch fixes build problems under gcc 3.4 - gnuradio-3.1.1-templates.tar.gz includes files that aren't in official tar ball, upstream just "forgot" :) - rpmlint is kinda sane now
Koji build F8: http://koji.fedoraproject.org/koji/taskinfo?taskID=491021
Wow, this is much better. 1.) I can not believe this worked: :) # $ tar -cf gnuradio-3.1.1-templates.tar gnuradio-core/src/lib/gengen/*.t && gzip gnuradio-3.1.1-templates.tar ... tar -xvvf %{SOURCE1} mv *.t gnuradio-core/src/lib/gengen/ However, you could shorten the comment with -czf :) And the proper way to unpack is to use %setup macro --- it can do that! Also why do you move those *.t files? Doesn't tar preserve paths while unpacking? And you don't uncompress the archive -- did that work? And why do you pass two -v-s? 2.) PATH=/usr/libexec/sdcc:$PATH %{_libexecdir} here? 3.) in %files: Please replace the doc/ directory location with %{docdir} in %{_datadir}/doc/usrp* The package is brewing in my mock now, I'll proceed once it builds. PS: Your gcc43 patch is awesome; I never seen that lon gcc43 patch yet :)
4.) you have the same %doc files in -doc and -examples 5.) Please look at the contents of -example package. Did you mean bytecode to go there? Either make these executable and move to bin or libexec, or (better) move them to doc. 6.) Nuke alsa-lib dependency. You don't depend on it. alsa-lib-devel does, though, so this is more of a cosmetic change, it will get pulled in anyway :) 7.) You install libtool files. Exclude them. example: /usr/lib64/python2.5/site-packages/gnuradio/gr/_gnuradio_swig_py_io.la 8.) The package should contain the text of the license Have you asked upstream?
10.) gnuradio-devel: /usr/lib64/libgnuradio-core-qa.so /usr/lib64/libgnuradio-core-qa.so.0 /usr/lib64/libgnuradio-core-qa.so.0.0.0 /usr/lib64/libgnuradio-core.so /usr/lib64/libgnuradio-core.so.0 /usr/lib64/libgnuradio-core.so.0.0.0 /usr/lib64/libgr_audio_alsa.so /usr/lib64/libgr_audio_alsa.so.0 /usr/lib64/libgr_audio_alsa.so.0.0.0 /usr/lib64/libgromnithread.so /usr/lib64/libgromnithread.so.0 /usr/lib64/libgromnithread.so.0.0.0 Why do you pack shared libraries in -devel? -devel should not be required for vital package functionality! Hint: In most cases, *.so belong to -devel. Versioned ones never do. 11.) gnuradio-doc; maybe this is not a problem, just a question: You have directory /usr/share/doc/usrp-3.1.1 The package that you build is called gnuradio-usrp Wouldn't it make sense to either rename the package to usrp, or the doc directory to gnuradio-usrp-3.1.1? (given what are the filenames in that package, I'd go for the first and would put the usrp documentation into that package)
Spec URL: http://mmahut.fedorapeople.org/reviews/gnuradio/gnuradio.spec SRPM URL: http://mmahut.fedorapeople.org/reviews/gnuradio/gnuradio-3.1.1-1.fc8.src.rpm All 10 issues has been addresses. Regarding 11), you're right, debian project is also using "usrp" as name of the package.
I am still wondering whether it makes sense to compile the example files: /usr/share/gnuradio/examples/usrp/fm_tx4.py /usr/share/gnuradio/examples/usrp/fm_tx4.pyc /usr/share/gnuradio/examples/usrp/fm_tx4.pyo
It does not really. Until bug 182498 is fixed I've excluded it from the spec file manually. Spec URL: http://mmahut.fedorapeople.org/reviews/gnuradio/gnuradio.spec SRPM URL: http://mmahut.fedorapeople.org/reviews/gnuradio/gnuradio-3.1.1-1.fc8.src.rpm
Several times looking at this over and over -- couldn't find anything more :) I'm happy with this now, thanks for the package! APPROVED
Thank you Lubomir, New Package CVS Request ======================= Package Name: gnuradio Short Description: Software defined radio framework Owners: mmahut Branches: F-8 InitialCC: astronomy-sig Cvsextras Commits: yes
cvs done.
Thank you Kevin, Thank you Lubomir, Imported and build in rawhide and awaiting update for Fedora 8 (FEDORA-2008-2435).
Package Change Request ====================== Package Name: gnuradio New Branches: EL-5
Thank you, tracking in Bug 443921
Package Change Request ====================== Package Name: gnuradio New Branches: epel7 Owners: jskarvad InitialCC:
Git done (by process-git-requests).