The patch to fix arcmsr_iop_message_xfer() which is called from atomic context under the queuecommand in scsi_host_template handler. GFP_KERNEL|GFP_DMA flags are wrong: firstly we are in atomic context, secondly this memory is not used for DMA. GFP_ATOMIC is a correct flag.
Created attachment 296858 [details] The patch for arcmsr-1.20.00.15.RH-80227
Nick, you are removing in this patch the "-static void arcmsr_shutdown(struct pci_dev *pdev)" again. What is the reason for that ?
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release.
Hi Tomas, I remember it is not supported in RHEL5.1. Therefore I delete it intuitively. I will check it again.
Created attachment 296873 [details] Renew the early patch
Nick,please could you also have a look at the patch from bz#428801 ?
Tomas, does Red Hat have everything we need here from Nick at Areca?
Created attachment 314697 [details] Restructured patch Nick, Andrius, I've recreated this patch. Besides of omitting some unneeded whitespace changes I also removed : @@ -1888,7 +1885,6 @@ static void arcmsr_polling_hba_ccbdone(s , ccb); ccb->pcmd->result = DID_ABORT << 16; arcmsr_ccb_complete(ccb, 1); - poll_ccb_done = 1; continue; } printk(KERN_NOTICE "arcmsr%d: polling get an illegal ccb" this is not upstream and I believe it was in the patch by mistake again. Nick, please review this patch.
Posted today without the hunk from comment #9.
Tomas, Sorry for my neglect. I will check it and reply later.
Hi Tomas, If you mean you will remove the entry of "poll_ccb_done = 1", please go ahead. It should not be there. Thank you,
in kernel-2.6.18-109.el5 You can download this test kernel from http://people.redhat.com/dzickus/el5
Sorry for delay. I have tested it this morning. No matter what it will be, I will report on the BZ. Thanks,
Don, The test is still working so far so good. There are no error messages. For your information,
*** Bug 460789 has been marked as a duplicate of this bug. ***
For those looking for an immediate work-around: Use a kernel from http://people.redhat.com/dzickus/el5/. [^] kernel-2.6.18-118.el5.x86_64 works for me for Areca 1170. See also http://bugs.centos.org/view.php?id=3070 and http://www.centos.org/modules/newbb/viewtopic.php?topic_id=15640
Tomas, please add a draft for the release note of this bug (in the "Release Notes" field). thanks!
also, please include a list of bug fixes and enhancements applied by this update to arcmsr.
Release note added. If any revisions are required, please set the "requires_release_notes" flag to "?" and edit the "Release Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. New Contents: The patch fixes arcmsr_iop_message_xfer() which is called from atomic context under the queuecommand in scsi_host_template handler. GFP_KERNEL|GFP_DMA flags here were are wrong, firstly we are in atomic context, secondly this memory is not used for DMA.
thanks Tomas. clearing release notes flag, field, and tracker.
Deleted Release Notes Contents. Old Contents: The patch fixes arcmsr_iop_message_xfer() which is called from atomic context under the queuecommand in scsi_host_template handler. GFP_KERNEL|GFP_DMA flags here were are wrong, firstly we are in atomic context, secondly this memory is not used for DMA.
Partners, this bug should be fixed in the latest RHEL 5.3 Snapshot. We believe that you have some interest in its correct functionality, so we're making a friendly request to send us some testing feedback. If you have a chance to test it, please share with us your findings. If you have successfully VERIFIED the fix, please add PartnerVerified to the Bugzilla keywords, along with a description of the results. Thanks!
~~ Snapshot 6 is out ~~ Partners, please test and let us know if this bug has been fixed. Add PartnerVerified keyword if everything works as expected. For any new issues encountered, CLONE this bug and report the issues in the new bug.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2009-0225.html
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days