*** Bug 227073 has been marked as a duplicate of this bug. ***

It seems that junit is needed for BuildRequires?
http://koji.fedoraproject.org/koji/taskinfo?taskID=516868

Yes, but the way their build process is set up it tries to fetch junit from the 
web instead of using the system junit -- or something. I'm not completely sure 
how to fix this yet, but I'm working on it.

Created attachment 298198 [details]
patch to prevent from junit downloading

I am not java expert (and my knowledge about java is very little).
however applying the patch attached and adding "BR: junit" seems
to pass rebuild.

http://koji.fedoraproject.org/koji/taskinfo?taskID=518665

Thank you very much.

New URLs:
Spec URL: http://konradm.fedorapeople.org/fedora/SPECS/joda-time.spec
SRPM URL: 
http://konradm.fedorapeople.org/fedora/SRPMS/joda-time-1.5.2-2.fc8.src.rpm

For 1.5.2-2:

* Requires
  - For -javadocs subpackages:
-----------------------------------------------------
Requires:       %{name}-%{version}-%{release}
                      ^^^^
-----------------------------------------------------
    This must be %{name} = %{version}-%{release}

* src/testdata/
  - The files under src/testdata seem binary (although
    I can see almost all parts by less command).
    If they can safely be igored, please remove all of
    them at %prep (I don't know if they can be removed,
    however even if they are removed joda-time compiles:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=519102 )

* tzdata
  - This package uses tzdata (please check files under
    src/java/org/joda/time/tz/src/) and the version is
    2007k.

    However from
    ftp://elsie.nci.nih.gov/pub/
    it seems current latest tzdata is 2008a (you can find 
    tzdata2008a.tar.gz from the URL above) and tzdata of Chile
    is revised.
    ! Note
      Current Fedora rawhide tzdata is also 2007k, however changelog
      shows Fedora tzdata maintainer patched for Chilean tzdata
      and essentially it is the same as 2008a.
    The history of joda-time shows the upstream does not always
    sync tzdata part with the URL above.

    IMO
    - This package should have tzdataXXXXx.tar.gz as Source(1,
      for example) and override files under src/java/org/joda/time/tz/src/
      by the files in tzdata tarball.
      This means that you have to update joda-time every time
      tzdata is updated (usually you can notice by Fedora tzdata update).

      Also, in this case it is better that the EVR (Epoch-Version-Release)
      of tzdata refects the version of tzdata used for joda-time
      (say, 1.5.2-2.tzdata2008a.fc9?).

    - Or are there any way thatjoda-time use contents in tzdata rpm
      directly?

* Documents
  - IMO it is better that the following files is added
    to %doc.
-----------------------------------------------------
RELEASE-NOTES.txt
ToDo.txt
-----------------------------------------------------

* javadoc
  - Mark both
-----------------------------------------------------
%dir %{_javadocdir}/%{name}-%{version}
%{_javadocdir}/%{name}-%{version}/*
-----------------------------------------------------
    as %doc.
  ! Note
    The above two lines can be replaced by
-----------------------------------------------------
%doc %{_javadocdir}/%{name}-%{version}/
-----------------------------------------------------
    The %files entry <a_directory>/ (not %dir <a_directory>)
    contains the directory itself and all files/directories/etc
    under the directory.

Note:
tzdata is Public Domain and you can freely use it.

I have incorporated all of your suggestions in to my local spec except for those
concerning tzdata (because I'm not done yet).

I have tried in a number of different ways to use the system tzdata, but cannot
seem to get that to work (it might work but needs love from someone who knows
the ins and outs of java/ant). I will go ahead and use 2008a from your link, and
include "tzdata2008a" in Release.

New URLs:
Spec URL: http://konradm.fedorapeople.org/fedora/SPECS/joda-time.spec
SRPM URL: 
http://konradm.fedorapeople.org/fedora/SRPMS/joda-time-1.5.2-3.tzdata2008a.fc8.src.rpm

Okay. tzdata replacing seems to be working good.

One thing:
- From rpmlint:
-------------------------------------------------------------------
$ rpmlint joda-time
joda-time.noarch: W: incoherent-version-in-changelog 1.5.2-3 1.5.2-3.tzdata2008a.fc9
-------------------------------------------------------------------
  Please change %changelog to
-------------------------------------------------------------------
%changelog
* Mon Mar 17 2008 Conrad Meyer <konrad@tylerc.org> - 1.5.2-3.tz2008a
-------------------------------------------------------------------
  before importing this to CVS.

-------------------------------------------------------------------
             This package (joda-time) is APPROVED by me
-------------------------------------------------------------------

OK. I'll wait on requesting CVS until we arrive at some conclusion about the 
status of java packaging.

Also: I'm not sure what the distinction is between tzdata and tzdata-java, but 
perhaps the latter could be used instead of shipping our own. I'll take a stab 
at it while we await FESCo's response.

Conrad, now
- Java packaging guidelines seems established
- Current tzdata is 2008b

So would you update this package again so that I can check
this package later?

(In reply to comment #13)
> Conrad, now
> - Java packaging guidelines seems established
> - Current tzdata is 2008b
> 
> So would you update this package again so that I can check
> this package later?

Yep. Thanks for your patience!

New URLs:
http://konradm.fedorapeople.org/fedora/SPECS/joda-time.spec
http://konradm.fedorapeople.org/fedora/SRPMS/joda-time-1.5.2-4.tzdata2008b.fc8.src.rpm

Sorry for the delay, I've been busy these last few days.

Well, I just tried to rebuild but it failed (on dist-f9)

http://koji.fedoraproject.org/koji/taskinfo?taskID=551844

Bummer. I'd guess it's a GCJ problem (since it builds just fine in 
java-1.6.0-openjdk).

New spec and SRPM sans AOT bits:
Spec: http://konradm.fedorapeople.org/fedora/SPECS/joda-time.spec
SRPM: 
http://konradm.fedorapeople.org/fedora/SRPMS/joda-time-1.5.2-5.tzdata2008b.fc8.src.rpm

Koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=551879

Okay.

-------------------------------------------------------------------------------
           This package (joda-time) is APPROVED by me (again)
-------------------------------------------------------------------------------

New Package CVS Request
=======================
Package Name: joda-time
Short Description: Java date and time API
Owners: konradm
Branches: F-8
InitialCC: 
Cvsextras Commits: yes

cvs done.

Package Change Request
======================
Package Name: joda-time
New Branches: EL-5

cvs done.