Spec URL: http://nim.fedorapeople.org/edrip-fonts.spec SRPM URL: http://nim.fedorapeople.org/edrip-fonts-20080310-1.fc9.src.rpm Description: Edrip is a contrast sans-serif font. It is based on the Teams font released on 2000 by TopTeam Co. Edrip contains symbols for basic Cyrillic and Latin alphabets.
Can you get Spot/Fedora legal to check over the license here? The note in the spec file makes my head spin. ;) Also, note that this package needs xgridfit, which is not yet available in rawhide due to the beta freeze.
(In reply to comment #1) > Can you get Spot/Fedora legal to check over the license here? > The note in the spec file makes my head spin. ;) I'm blocking FE-LEGAL now. It made my head spin too, I hoped the note would be clear enough > Also, note that this package needs xgridfit, which is not yet available in > rawhide due to the beta freeze. You can test build in mock if you configure the koji repositories directly
I'm ok with this, even if it does make my head hurt, the logic seems solid. Lifting FE-Legal.
ok. Happy to review this package now. Look for a full review in a bit.
OK - Meets Packaging Guidelines. OK - License (OFL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 066f36f19f8a5c817028ad5e99210478 edrip-src-20080310.tar.bz2 066f36f19f8a5c817028ad5e99210478 edrip-src-20080310.tar.bz2.sav OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag See below - Should package latest version Issues: 1. 20080318 is out, perhaps update to that before importing? 2. The Source0: %{URL}/%{archivename}.tar.bz2 doesn't seem to work with spectool. Why not just replace %{URL} with the URL. Do you expect it to keep changing? Why not replace %{archivename} with the more standard %{name}-src-%{release} ? It would be good for spectool -g to work with your Source0 line in any case. Neither of those is a big deal, if you could look at them before importing, that would be great. This package is APPROVED.
Ok, will look at it at import time New Package CVS Request ======================= Package Name: edrip-fonts Short Description: Edrip decorative fonts Owners: nim Branches: devel InitialCC: fonts-sig Cvsextras Commits: Yes
cvs done. Any chance for F7 and F8? (or do we need to update fontforge back there first?)
> 1. 20080318 is out, perhaps update to that before importing? done > 2. The > Source0: %{URL}/%{archivename}.tar.bz2 > doesn't seem to work with spectool. This is a spectool problem. Open a spectool bug if you care (I don't) > Why not just replace %{URL} with the URL. Do you expect it to keep changing? I suck at keeping URLs in sync. The less I have to manage the better I feel (I still remember the 13-package gfs rebuild for upstream move with dread) > Why not replace %{archivename} with the more standard %{name}-src-%{release} ? Standard is in the eye of the beholder. I maintain and saw many packages that used %{archivename} Anyway package is now imported, thanks for the review